-
Notifications
You must be signed in to change notification settings - Fork 229
Add 'tag_pattern' feature to git dependencies #4427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sigurdm
wants to merge
26
commits into
dart-lang:master
Choose a base branch
from
sigurdm:git_version_by_tag
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+852
−184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonasfj
reviewed
Nov 15, 2024
jonasfj
reviewed
Nov 15, 2024
jonasfj
reviewed
Nov 15, 2024
jonasfj
approved these changes
May 12, 2025
Comment on lines
-84
to
+78
required Description containingDescription, | ||
required ResolvedDescription containingDescription, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I kind of wish this migration could have been done in steps.
- Change
Description
->ResolvedDescription
- Move
hasMultipleVersions
- Adopt usage of
hasMultipleVersions
instead ofis HostedSource
- ..
- Support for
tag-pattern
But I can also see how it would cause a lot of conflicts to do that.
Co-authored-by: Jonas Finnemann Jensen <[email protected]>
This was referenced May 13, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: #1250
With this proposal you can use a git repo as a versioned package repository.
For example write:
And all commits in the git repo that are tagged according to
v{{version}}
will be inspected. If they contain a pubspec.yaml withname: foo
and the correct version number they will be considered for resolution.This feature is explicitly opt-in:
git
dependency without atag_pattern
retain the existing behavior.