Fix(html): Handle <br> elements to insert line breaks in text

pkgs/html/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 0.15.5+1
+
+- Fix a bug in DOM parsing where `<br>` tags does not create a new line when html is converted to text.
+
 ## 0.15.5
 
 - Require Dart `3.2`.

pkgs/html/lib/dom_parsing.dart

@@ -43,7 +43,14 @@ class TreeVisitor {
   void visitText(Text node) => visitNodeFallback(node);
 
   // TODO(jmesserly): visit attributes.
-  void visitElement(Element node) => visitNodeFallback(node);
+  void visitElement(Element node) {
+    if (node.localName == 'br') {
+      visitText(Text('\n'));
+      return;
+    }
+
+    visitNodeFallback(node);
+  }
 
   void visitComment(Comment node) => visitNodeFallback(node);
 

pkgs/html/pubspec.yaml

@@ -1,5 +1,5 @@
 name: html
-version: 0.15.5
+version: 0.15.5+1
 description: APIs for parsing and manipulating HTML content outside the browser.
 repository: https://github.com/dart-lang/tools/tree/main/pkgs/html
 issue_tracker: https://github.com/dart-lang/tools/issues?q=is%3Aissue+is%3Aopen+label%3Apackage%3Ahtml

pkgs/html/test/parser_feature_test.dart

@@ -265,11 +265,11 @@ On line 4, column 3 of ParseError: Unexpected DOCTYPE. Ignored.
   });
 
   test('Element.text', () {
-    final doc = parseFragment('<div>foo<div>bar</div>baz</div>');
+    final doc = parseFragment('<div>foo<div><br>bar</div>baz<br></div>');
     final e = doc.firstChild!;
     final text = e.firstChild!;
     expect((text as Text).data, 'foo');
-    expect(e.text, 'foobarbaz');
+    expect(e.text, 'foo\nbarbaz\n');
 
     e.text = 'FOO';
     expect(e.nodes.length, 1);
@@ -279,15 +279,15 @@ On line 4, column 3 of ParseError: Unexpected DOCTYPE. Ignored.
   });
 
   test('Text.text', () {
-    final doc = parseFragment('<div>foo<div>bar</div>baz</div>');
+    final doc = parseFragment('<div>foo<div>bar</div><br>baz</div>');
     final e = doc.firstChild!;
     final text = e.firstChild as Text;
     expect(text.data, 'foo');
     expect(text.text, 'foo');
 
     text.text = 'FOO';
     expect(text.data, 'FOO');
-    expect(e.text, 'FOObarbaz');
+    expect(e.text, 'FOObar\nbaz');
     expect(text.text, 'FOO');
   });