[interop] Add support for modules #446
Conversation
| Set<TSNode> get nodes; | ||
|
|
||
| final Set<ParentDeclaration> namespaceDeclarations; |
There was a problem hiding this comment.
Should this not be Set<NamespaceDeclaration>?
There was a problem hiding this comment.
would there be a reason for it to be null?
There was a problem hiding this comment.
I might be missing something. :) I meant that this says "namespaceDeclarations" but the type of the Set isn't more specific. If this also encompasses module declarations I'd rename the field to represent both.
There was a problem hiding this comment.
Oh my bad, VSCode made it look like you were writing the question mark as a nullable symbol rather than the entirety as a question.
|
|
||
| for (final decl in topLevelDeclarations) { | ||
| if (decl case final VariableDeclaration variable) { | ||
| if (variable.modifier == VariableModifier.$const) { |
There was a problem hiding this comment.
I'd avoid the code duplication and let emit handle this check and then just type-check the result before adding it to the lists, even if it means an extra type-check.
Fixes #424
Fixes #431
This PR adds support for TypeScript Modules, as well as TS Preprocessing, reference modules, and more!