Skip to content

Remove dependency overrides. #2634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

davidmorgan
Copy link
Contributor

Now that build_runner 2.5.0 is published :)

@davidmorgan
Copy link
Contributor Author

I'm not quite sure what to do with buildRunnerConstraint ... I updated it for the tests to 2.5.0 since that's the version with the changed log messages, but it looks like buildRunnerConstraint will check what users are using? They don't have to update to 2.5.0.

@srujzs
Copy link
Contributor

srujzs commented Jun 16, 2025

I think we might be able to just upgrade the hard-coded constraint especially since it's a dev dependency, but maybe @bkonyi knows more? It looks like that's what we've done before. Maybe we should adopt a version range instead? e.g. https://github.com/dart-lang/webdev/blame/f978b90cdfc97967b8caec1b5e2a4919ce9fa3d2/webdev/lib/src/pubspec.dart

@bkonyi
Copy link
Collaborator

bkonyi commented Jun 16, 2025

I'm not sure why buildRunnerConstraint needs to be changed if the range already includes 2.5.0. Am I missing something?

For the failing e2e_test.dart, I think we can just update the expectation to look for ^2.5.0.

@srujzs
Copy link
Contributor

srujzs commented Jun 16, 2025

I believe we're checking that the constraint is the same e.g. ^2.4.0 == ^2.4.0, not that the version lies within that constraint.

I'm not sure why buildRunnerConstraint needs to be changed if the range already includes 2.5.0.

Sorry, ignore my last sentence about using a version range. The issue would be the same whenever we need to update the constraint.

@bkonyi
Copy link
Collaborator

bkonyi commented Jun 16, 2025

I believe we're checking that the constraint is the same e.g. ^2.4.0 == ^2.4.0, not that the version lies within that constraint.

We're talking about the failure in e2e_test.dart right? I think that's fine to fail on version changes in this test as it's checking that we're using consistent versions across the test projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants