Fix duplicate connection/logs in Webdev #2635
Open
+55
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 2ccd2d9.
jyameo
changed the title
|
autosubmit label was removed for dart-lang/webdev/2635, because - The status or check suite publish / validate has failed. Please fix the issues identified (or deflake) before re-applying this label. |
bkonyi
reviewed
Jun 19, 2025
| @@ -121,8 +111,7 @@ class AppDomain extends Domain { | |||
| appConnection.runMain(); | |||
|
|
|||
| unawaited(debugConnection.onDone.whenComplete(() { | |||
| appState.dispose(); | |||
| _appStates.remove(appId); | |||
| _cleanupAppConnection(appId, appState); | |||
There was a problem hiding this comment.
Won't this result in the streams being cancelled once the first DebugConnection closes, even if a more recent connection to the same appId has been established?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix duplicate app logs on page refresh in Webdev
Fixes: #2604
Problem
Each page refresh created duplicate stdout listeners for the same app, causing exponential log duplication (1 log → 2 logs → 3 logs, etc.).
Root Cause
app_domain.dart created new VM service stdout listeners on every dwds.connectedApps event without checking if listeners already existed for the same appId.
Solution
Added simple tracking to prevent duplicate listeners:
Changes
app_domain.dart: Added listener deduplication with minimal code changes
Result