-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: load class items count only when project ontology is selected d… #2065
Open
irmastnt
wants to merge
8
commits into
main
Choose a base branch
from
feature/dev-4468-typeerror-cannot-read-properties-of-undefined-reading
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix: load class items count only when project ontology is selected d… #2065
irmastnt
wants to merge
8
commits into
main
from
feature/dev-4468-typeerror-cannot-read-properties-of-undefined-reading
+39
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uring resource deletion. (DEV-4498)
…rties-of-undefined-reading
…rties-of-undefined-reading
derschnee68
previously approved these changes
Feb 3, 2025
…rties-of-undefined-reading
derschnee68
previously approved these changes
Feb 3, 2025
…rties-of-undefined-reading * main: (66 commits) fix: bring back, fix and improve some translations (DEV-4676) (#2161) fix: remove unused translations (DEV-4598) (#2148) fix: pendo only receives data from 'prod' (#2160) refactor: move some user components to the right lib (#2149) fix: properties style alignment (#2153) style: change align-items values from start to flex-start (#2156) fix: pass viewContainerRef (DEV-4671) (#2154) chore(deps-dev): bump @types/node from 20.17.19 to 20.17.23 in the types-deps group (#2147) chore(deps): bump @sentry/cli from 2.41.1 to 2.42.2 in the sentry-deps group (#2145) chore(deps-dev): bump postcss from 8.5.2 to 8.5.3 in the postcss-deps group (#2144) chore(deps-dev): bump ts-jest from 29.2.5 to 29.2.6 in the jest-deps group (#2143) chore(deps): bump the grafana-deps group with 2 updates (#2142) chore: add entries to Dependabot file (#2141) chore(main): release 11.26.2 (#2136) fix: highlights value from route and redesign the properties in the resource editor (#2134) refactor: remove unused route (#2139) refactor: remove unused code (#2137) fix: resource editor manages its own resource deletion (#2138) fix: navigate after deletion (#2125) fix: compoundService reset on change of resource (#2135) ... # Conflicts: # libs/vre/resource-editor/resource-editor/src/lib/resource-header.component.ts
…rties-of-undefined-reading * main: refactor: remove unused code (#2151) # Conflicts: # libs/vre/resource-editor/resource-editor/src/lib/resource-header.component.ts
@domsteinbach I restored functionality related to the afterResourceDeleted event. Do you know why it was removed? |
…rties-of-undefined-reading
I don't think it's valid anymore with the new resource editor architecture
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…uring resource deletion. (DEV-4498)
resolves DEV-