Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: load class items count only when project ontology is selected d… #2065

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

irmastnt
Copy link
Contributor

…uring resource deletion. (DEV-4498)

resolves DEV-

Copy link

linear bot commented Jan 27, 2025

derschnee68
derschnee68 previously approved these changes Feb 3, 2025
derschnee68
derschnee68 previously approved these changes Feb 3, 2025
@mpro7 mpro7 changed the title fix: loads class items count only when project ontology is selected d… fix: load class items count only when project ontology is selected d… Feb 10, 2025
…rties-of-undefined-reading

* main: (66 commits)
  fix: bring back, fix and improve some translations (DEV-4676) (#2161)
  fix: remove unused translations (DEV-4598) (#2148)
  fix: pendo only receives data from 'prod' (#2160)
  refactor: move some user components to the right lib (#2149)
  fix: properties style alignment (#2153)
  style: change align-items values from start to flex-start (#2156)
  fix: pass viewContainerRef (DEV-4671) (#2154)
  chore(deps-dev): bump @types/node from 20.17.19 to 20.17.23 in the types-deps group (#2147)
  chore(deps): bump @sentry/cli from 2.41.1 to 2.42.2 in the sentry-deps group (#2145)
  chore(deps-dev): bump postcss from 8.5.2 to 8.5.3 in the postcss-deps group (#2144)
  chore(deps-dev): bump ts-jest from 29.2.5 to 29.2.6 in the jest-deps group (#2143)
  chore(deps): bump the grafana-deps group with 2 updates (#2142)
  chore: add entries to Dependabot file (#2141)
  chore(main): release 11.26.2 (#2136)
  fix: highlights value from route and redesign the properties in the resource editor (#2134)
  refactor: remove unused route (#2139)
  refactor: remove unused code (#2137)
  fix: resource editor manages its own resource deletion (#2138)
  fix: navigate after deletion (#2125)
  fix: compoundService reset on change of resource (#2135)
  ...

# Conflicts:
#	libs/vre/resource-editor/resource-editor/src/lib/resource-header.component.ts
@irmastnt irmastnt requested a review from domsteinbach as a code owner March 7, 2025 10:30
irmastnt added 2 commits March 7, 2025 13:06
…rties-of-undefined-reading

* main:
  refactor: remove unused code (#2151)

# Conflicts:
#	libs/vre/resource-editor/resource-editor/src/lib/resource-header.component.ts
@irmastnt
Copy link
Contributor Author

irmastnt commented Mar 7, 2025

@domsteinbach I restored functionality related to the afterResourceDeleted event. Do you know why it was removed?

@derschnee68 derschnee68 dismissed their stale review March 11, 2025 10:23

I don't think it's valid anymore with the new resource editor architecture

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants