Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

binary release fixes + install info #918

Merged
merged 4 commits into from
Jan 18, 2018
Merged

binary release fixes + install info #918

merged 4 commits into from
Jan 18, 2018

Conversation

joehand
Copy link
Collaborator

@joehand joehand commented Jan 17, 2018

Finishing support for Dat binary releases! The last issue is getting UTP native included in the release. Right now pkg doesn't support including native modules in the package, so we'll put the binary plus .node file together in a folder for folks to download.

  • get WASM builds in binary
  • add native modules to travis release thing
  • add install info to readme
  • add download button to docs
  • write basic install script (?)

ARM builds have a few blockers:

@joehand joehand changed the title WIP: final binary release fixes binary release fixes + install info Jan 17, 2018
@joehand
Copy link
Collaborator Author

joehand commented Jan 18, 2018

(will add download button once we can get that .node file included.

@joehand joehand merged commit 4811709 into master Jan 18, 2018
@joehand joehand deleted the fix-package-wasm branch January 18, 2018 21:39
@TemaSM
Copy link

TemaSM commented Feb 9, 2018

@joehand What about Win ia32 prebuild? I think, that not only I need it.
Cannot compile utp-native and bundle it with dat Windows x86 built binary, using Nexe or pkg as packaging tool.
Will appreciate you so much for any advice on how to make build dat for Windows x86 with utp-native.

UPD: Figured out what was wrong and compiled successfully using pkg, but now I should provide not just binary, but .node native along with it, not excellent as Nexe, but Nexe doesn't wanna work fine with dat.

@joehand
Copy link
Collaborator Author

joehand commented Feb 9, 2018

Great you got it working! Including win 32 build is okay with me, feel free to PR the necessary additions to support that.

Figured out what was wrong and compiled successfully using pkg, but now I should provide not just binary, but .node native along with it, not excellent as Nexe, but Nexe doesn't wanna work fine with dat.

Ya it's a bit tricky. I tried both for awhile and pkg was much easier in the end except for the native module part. We are hoping eventually we can also bundle the .node files: vercel/pkg#329

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants