Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed telemetry code in frontend #28

Merged
merged 1 commit into from
Jan 12, 2023
Merged

removed telemetry code in frontend #28

merged 1 commit into from
Jan 12, 2023

Conversation

phamrachel17
Copy link
Collaborator

No description provided.

@WinbertZhang
Copy link
Collaborator

WinbertZhang commented Jan 11, 2023 •
edited
Loading

@JasonFreeberg Can you confirm if these changes resolve issue 18 from crunchtime regarding A/B testing? crunch-time/crunchtime#18

@JasonFreeberg JasonFreeberg merged commit a9b880a into main Jan 12, 2023
@JasonFreeberg
Copy link
Collaborator

@phamrachel17 @WinbertZhang -- Approved and merged!

phamrachel17 added a commit that referenced this pull request Feb 8, 2023
@phamrachel17
removed track metric code that was causing error in console. part of …
a498d7f 
…pull request #28
@phamrachel17 phamrachel17 mentioned this pull request Feb 8, 2023
Merged
@WinbertZhang WinbertZhang deleted the 18-remove-ab-testing-code branch February 9, 2023 00:27
WinbertZhang added a commit that referenced this pull request Mar 8, 2023
@WinbertZhang
Squashed commit of the following:
58ceb0d 
commit 1b9ca0e
Merge: 9d6c36c 76460d3
Author: Winbert Zhang <[email protected]>
Date:   Tue Mar 7 18:17:21 2023 -0800

    Merge pull request #59 from data-science-ucsb/batch-bug-fixes

    Batch Bug Fixes

commit 9d6c36c
Merge: d6c0d57 1aa6c91
Author: Winbert Zhang <[email protected]>
Date:   Tue Mar 7 17:56:46 2023 -0800

    Merge pull request #68 from data-science-ucsb/Bug-fix-App-still-works-when-entered-max-min-units

    Bug fix app still works when entered max min units

commit 1aa6c91
Author: Gen Tamada <[email protected]>
Date:   Sat Mar 4 14:48:19 2023 -0800

    check if max unit is less than 20

commit 53b861f
Author: Gen Tamada <[email protected]>
Date:   Sat Mar 4 14:45:54 2023 -0800

    Fixed bug

    Now, the min and max are connected to their own "check" variable, which is not directly connected to the api call. So when the min and max are changed, on event blur or pressing enter, it will run the check function for the following criteria: if min < max, if min and max are integers, if min and max are numbers at all, and if min < 0.

commit 76460d3
Author: Ramon Wang <[email protected]>
Date:   Tue Feb 28 22:31:43 2023 -0800

    fixed test error

commit 837071b
Author: Ramon Wang <[email protected]>
Date:   Tue Feb 28 21:56:21 2023 -0800

    batch bug fixes

commit d6c0d57
Merge: 185a0e8 f1039f5
Author: Ponmo <[email protected]>
Date:   Sun Feb 26 16:16:52 2023 -0800

    Merge pull request #56 from data-science-ucsb/schedule-builder-vue

    Implemented schedule builder Vue + Batch bug fixes and changes

commit f1039f5
Author: Ponmo <[email protected]>
Date:   Sun Feb 26 16:07:09 2023 -0800

    Changed white text color to black in custom sched builder

commit 0a69d5a
Author: Ponmo <[email protected]>
Date:   Sun Feb 26 15:34:40 2023 -0800

    Centered navbar titles

commit ab447bb
Merge: b8d3cb3 185a0e8
Author: Ponmo <[email protected]>
Date:   Sun Feb 26 15:24:30 2023 -0800

    Merge branch 'main' into schedule-builder-vue

commit b8d3cb3
Author: Ponmo <[email protected]>
Date:   Sun Feb 26 15:23:00 2023 -0800

    Added nav title for current view, removed double and single schedule views, and added opacity to unselected events in schedule builder view

commit 185a0e8
Merge: b6e25f6 6a03b9c
Author: Winbert Zhang <[email protected]>
Date:   Sun Feb 26 14:54:49 2023 -0800

    Merge pull request #57 from data-science-ucsb/32-bug-change-some-of-the-colors-hard-to-read

    Changed Calendar Text Color to Black

commit 6a03b9c
Author: Johnsonchan105 <[email protected]>
Date:   Sat Feb 25 21:01:58 2023 -0800

    changed text color for calendar from white to black, this could be a temporary or permanent change as more suitable colors could be found for white text

commit e2928b7
Author: Ponmo <[email protected]>
Date:   Sat Feb 25 19:20:12 2023 -0800

    Fixed frontend testing error

commit b601964
Author: Ponmo <[email protected]>
Date:   Sat Feb 25 19:17:11 2023 -0800

    Fixed frontend testing error

commit 6e2f832
Author: Ponmo <[email protected]>
Date:   Sat Feb 25 19:08:35 2023 -0800

    Moved and deleted TODO's

commit 28ddbbf
Merge: 43abd7f b6e25f6
Author: Ponmo <[email protected]>
Date:   Sat Feb 25 18:59:16 2023 -0800

    Merged

commit 43abd7f
Author: Ponmo <[email protected]>
Date:   Sat Feb 25 18:26:24 2023 -0800

    Save custom schedule implementation

commit b6e25f6
Merge: 4c87b1a d5f148c
Author: Winbert Zhang <[email protected]>
Date:   Fri Feb 24 01:56:55 2023 -0800

    Merge pull request #55 from data-science-ucsb/toggle-course-selector

    Resolved issue 49: Added functionality of minimizing course selectors box

commit 6176264
Merge: 7480da9 1aad622
Author: Ponmo <[email protected]>
Date:   Wed Feb 22 20:33:26 2023 -0800

    Merge branch 'schedule-builder-vue' of https://github.com/data-science-ucsb/gauchocourses into schedule-builder-vue

commit 7480da9
Author: Ponmo <[email protected]>
Date:   Wed Feb 22 20:33:20 2023 -0800

    Setting up saving custom schedules

commit 1aad622
Author: Ramon Wang <[email protected]>
Date:   Wed Feb 22 20:32:51 2023 -0800

    Default time range filter set to max

commit 28b6547
Author: Ramon Wang <[email protected]>
Date:   Wed Feb 22 20:02:20 2023 -0800

    Fixed: favorited schedules load after page reload

commit 7974b69
Merge: 8ef4535 144d212
Author: Ponmo <[email protected]>
Date:   Wed Feb 22 18:46:13 2023 -0800

    Merge branch 'schedule-builder-vue' of https://github.com/data-science-ucsb/gauchocourses into schedule-builder-vue

commit 8ef4535
Author: Ponmo <[email protected]>
Date:   Wed Feb 22 18:46:05 2023 -0800

    Removed ScheduleB.vue

commit 144d212
Author: Ramon Wang <[email protected]>
Date:   Wed Feb 22 18:45:00 2023 -0800

    Check nullish enrolledTotal, instructor; fixed nonresponsive schedule width

commit 44af73a
Merge: fef2418 d425091
Author: Ponmo <[email protected]>
Date:   Tue Feb 21 21:41:21 2023 -0800

    Merge branch 'schedule-builder-vue' of https://github.com/data-science-ucsb/gauchocourses into schedule-builder-vue

commit fef2418
Author: Ponmo <[email protected]>
Date:   Tue Feb 21 21:41:08 2023 -0800

    Get rid of non-working minTime and maxTime calculation for Schedule.vue

commit d425091
Author: Ramon Wang <[email protected]>
Date:   Tue Feb 21 21:29:09 2023 -0800

    Fixed: profile pic does not load

commit 5215f6f
Author: Ramon Wang <[email protected]>
Date:   Tue Feb 21 21:27:27 2023 -0800

    Fixed alignment: schedule heart icon

commit 9a39094
Merge: eb0b905 7e209a1
Author: Ponmo <[email protected]>
Date:   Tue Feb 21 20:47:10 2023 -0800

    Fixed merge conflicts

commit eb0b905
Author: Ponmo <[email protected]>
Date:   Tue Feb 21 20:24:13 2023 -0800

    Added update schedule name to schedules on home page and fixed ListView

commit 7e209a1
Author: Ramon Wang <[email protected]>
Date:   Tue Feb 21 20:23:41 2023 -0800

    Added more info to tooltips

commit d4f9dae
Author: Ponmo <[email protected]>
Date:   Tue Feb 21 14:47:43 2023 -0800

    Updated alert conditionals in Paginator

commit 53e766a
Author: Ramon Wang <[email protected]>
Date:   Mon Feb 20 22:01:15 2023 -0800

    Denoted events as full if full

commit 3c390d3
Merge: 02a1175 916ed81
Author: Ponmo <[email protected]>
Date:   Mon Feb 20 20:22:16 2023 -0800

    Merge branch 'schedule-builder-vue' of https://github.com/data-science-ucsb/gauchocourses into schedule-builder-vue

commit 02a1175
Author: Ponmo <[email protected]>
Date:   Mon Feb 20 20:22:05 2023 -0800

    My Schedules page now does not show Custom Builder

commit 916ed81
Author: Ramon Wang <[email protected]>
Date:   Mon Feb 20 20:20:27 2023 -0800

    Reversed isLecture ternary statement

commit 9589fb2
Author: Ramon Wang <[email protected]>
Date:   Mon Feb 20 20:16:43 2023 -0800

    Display closed/full events

commit da6ae24
Author: Ramon Wang <[email protected]>
Date:   Mon Feb 20 20:02:00 2023 -0800

    Changed Github link

commit 5534d37
Merge: cc6e0b6 800f9ee
Author: Ponmo <[email protected]>
Date:   Mon Feb 20 19:55:46 2023 -0800

    Merge branch 'schedule-builder-vue' of https://github.com/data-science-ucsb/gauchocourses into schedule-builder-vue

commit cc6e0b6
Author: Ponmo <[email protected]>
Date:   Mon Feb 20 19:55:41 2023 -0800

    Adding Favoriting Schedule Builder

commit 800f9ee
Author: Ramon Wang <[email protected]>
Date:   Mon Feb 20 19:53:43 2023 -0800

    Event tooltips w/ extra info

commit 733d791
Author: Ponmo <[email protected]>
Date:   Sun Feb 19 22:22:28 2023 -0800

    Finished logic for schedule builder

commit 040748f
Author: Ponmo <[email protected]>
Date:   Fri Feb 17 22:35:03 2023 -0800

    Implemented manual schedule builder

commit 287cef6
Author: Ponmo <[email protected]>
Date:   Thu Feb 16 18:59:48 2023 -0800

    a

commit 2c641ea
Author: Ponmo <[email protected]>
Date:   Thu Feb 16 18:44:18 2023 -0800

    Checkpoint: old schedule data passed in

commit d5f148c
Author: Gen Tamada <[email protected]>
Date:   Wed Feb 15 16:33:59 2023 -0800

    Added chevron button for course selectors form group

    Made minor changed in main.js to import new chevron up icon from font-awesome
    Added isOpen state in CourseSelectors.js on v-show of content that needs to be closed
    Added toggleCourseSelector method in CourseSelectors.js to control the state of isOpen

commit 4c87b1a
Merge: 82583ce e79b749
Author: Cap Lee <[email protected]>
Date:   Wed Feb 15 08:18:25 2023 -0800

    Merge pull request #52 from data-science-ucsb/proxy-url-change

commit e79b749
Author: calee14 <[email protected]>
Date:   Tue Feb 14 23:15:15 2023 -0800

    backend proxy for prod

commit 82583ce
Merge: 2bb779b 5cb4425
Author: Cap Lee <[email protected]>
Date:   Sat Feb 11 13:19:25 2023 -0800

    Merge pull request #50 from data-science-ucsb/prod-config

    add env var for redis

commit 2bb779b
Merge: 2aa1862 bcf13e4
Author: Winbert Zhang <[email protected]>
Date:   Fri Feb 10 23:54:05 2023 -0800

    Merge pull request #48 from data-science-ucsb/sort-ges

    GE Sorting Bug

commit 2aa1862
Merge: e92ad69 a86152e
Author: Winbert Zhang <[email protected]>
Date:   Fri Feb 10 23:44:40 2023 -0800

    Merge pull request #47 from data-science-ucsb/pdf-export

    Pdf export

commit 4668458
Merge: 5a4705b e92ad69
Author: Ponmo <[email protected]>
Date:   Fri Feb 10 19:12:09 2023 -0800

    Merge branch 'main' of https://github.com/data-science-ucsb/gauchocourses

commit 5a4705b
Author: Ponmo <[email protected]>
Date:   Fri Feb 10 19:08:59 2023 -0800

    added schedule builder vue

commit 5cb4425
Author: calee14 <[email protected]>
Date:   Thu Feb 9 17:49:05 2023 -0800

    add env var for redis

commit a86152e
Author: Steven Choi <[email protected]>
Date:   Wed Feb 8 22:58:01 2023 -0800

    improved image quality, default value is 0.92 but changed to 1

commit bcf13e4
Author: Dan Le Man <[email protected]>
Date:   Wed Feb 8 21:36:59 2023 -0800

    Fixed GE sorting bug.

commit e92ad69
Merge: 8a886a1 69ef51c
Author: kshitij0407 <[email protected]>
Date:   Wed Feb 8 20:44:20 2023 -0800

    Merge pull request #46 from data-science-ucsb/add-disclaimer

    Add Disclaimer

commit 8a886a1
Merge: 278ec32 95598ac
Author: Winbert Zhang <[email protected]>
Date:   Wed Feb 8 20:43:06 2023 -0800

    Merge pull request #29 from data-science-ucsb/update-infobox-condition

    Updated selectedClassSection condition

commit 418c2ad
Author: Steven Choi <[email protected]>
Date:   Wed Feb 8 18:21:50 2023 -0800

    improved image ratio on pdf and captures entire schedule

commit 278ec32
Merge: a002661 a498d7f
Author: Winbert Zhang <[email protected]>
Date:   Wed Feb 8 16:21:18 2023 -0800

    Merge pull request #45 from data-science-ucsb/remove-telemetry-pt2

    removed track metric code that was causing error in console. part of …

commit 69ef51c
Author: Winbert Zhang <[email protected]>
Date:   Wed Feb 8 14:30:29 2023 -0800

    Add Disclaimer

    Adding a sentence about how GauchoCourses is not an official UCSB app to the about page.

commit a002661
Merge: 9a27782 0477235
Author: Ramon Wang <[email protected]>
Date:   Wed Feb 8 11:19:46 2023 -0800

    Merge pull request #40 from data-science-ucsb/25-update-backend-config-and-dependencies-to-use-mongodb

    25 update backend config and dependencies to use mongodb

commit a498d7f
Author: phamrachel17 <[email protected]>
Date:   Tue Feb 7 21:12:34 2023 -0800

    removed track metric code that was causing error in console. part of pull request #28

commit 9a27782
Merge: 0963243 d876c8f
Author: IrenaW2 <[email protected]>
Date:   Tue Feb 7 16:52:00 2023 -0800

    Merge pull request #44 from data-science-ucsb/azure-container-reg

    Push images to azure container registry

commit d876c8f
Author: calee14 <[email protected]>
Date:   Tue Feb 7 16:44:52 2023 -0800

    push images to azure container registry

commit 0963243
Merge: e819faf e4d0ffd
Author: Cap Lee <[email protected]>
Date:   Mon Feb 6 16:03:15 2023 -0800

    Merge pull request #42 from data-science-ucsb/azure-integration

commit e4d0ffd
Author: calee14 <[email protected]>
Date:   Mon Feb 6 14:15:32 2023 -0800

    test azure integration

commit 0477235
Author: Ramon Wang <[email protected]>
Date:   Mon Feb 6 12:48:13 2023 -0800

    Removed scope test from embed.mongo

commit e819faf
Merge: cf4a653 e22e8c9
Author: Winbert Zhang <[email protected]>
Date:   Sun Feb 5 22:20:36 2023 -0800

    Merge pull request #38 from data-science-ucsb/33-feature-logout-button-for-googleoauth

    Added logout button

commit 4be5c77
Author: Steven Choi <[email protected]>
Date:   Tue Jan 31 17:51:05 2023 -0800

    experiment with scale

commit cd7421a
Author: Steven Choi <[email protected]>
Date:   Tue Jan 31 17:27:21 2023 -0800

    pdf export works but need to fix margin/sizes

commit dc67648
Author: Ramon Wang <[email protected]>
Date:   Mon Jan 30 18:52:19 2023 -0800

    Added CosmosDB for MongoDB API support

commit e22e8c9
Author: Noah Wang <[email protected]>
Date:   Mon Jan 30 15:56:10 2023 -0800

    Added proxy for logout url

commit 6139b9f
Merge: cf4a653 a2a813e
Author: Noah Wang <[email protected]>
Date:   Mon Jan 30 15:53:53 2023 -0800

    fix local changesMerge remote-tracking branch 'origin/33-feature-logout-button-for-googleoauth'

commit cf4a653
Merge: 36bc981 9622e96
Author: Winbert Zhang <[email protected]>
Date:   Mon Jan 30 13:47:21 2023 -0800

    Merge pull request #27 from data-science-ucsb/day-count

    Display number of schedules next to each day

commit 9622e96
Merge: b241bcb 36bc981
Author: Winbert Zhang <[email protected]>
Date:   Mon Jan 30 13:41:21 2023 -0800

    Merge branch 'main' into day-count

commit 95598ac
Merge: fef71ca 36bc981
Author: Winbert Zhang <[email protected]>
Date:   Mon Jan 30 13:02:05 2023 -0800

    Merge branch 'main' into update-infobox-condition

commit 36bc981
Merge: 38c19ba d410016
Author: Winbert Zhang <[email protected]>
Date:   Mon Jan 30 13:00:21 2023 -0800

    Merge pull request #39 from data-science-ucsb/comma-after-ge-bug

    Comma after ge bug

commit d410016
Author: Winbert Zhang <[email protected]>
Date:   Mon Jan 30 12:54:51 2023 -0800

    Removing .vs files

commit de7f937
Merge: 4308924 38c19ba
Author: Winbert Zhang <[email protected]>
Date:   Mon Jan 30 12:43:08 2023 -0800

    Merge branch 'main' into comma-after-ge-bug

commit 4308924
Author: Dan Le Man <[email protected]>
Date:   Mon Jan 30 11:46:07 2023 -0800

    Implemented working solution.

commit c41a245
Author: Ramon Wang <[email protected]>
Date:   Sun Jan 29 17:22:44 2023 -0800

    Fixed ScheduleControllerTest 3

commit c510563
Author: Ramon Wang <[email protected]>
Date:   Sat Jan 28 23:46:56 2023 -0800

    Clarified comment

commit 5ff1c4e
Author: Dan Le Man <[email protected]>
Date:   Sat Jan 28 15:22:29 2023 -0800

    Initial fix. Redesigned GE solution to use a JS method that can better parse the GEs array.

commit 4e9652d
Author: Ramon Wang <[email protected]>
Date:   Fri Jan 27 22:47:19 2023 -0800

    Added comment 'uncomment line if mongo not working on local OS'

commit d194853
Author: Ramon Wang <[email protected]>
Date:   Fri Jan 27 21:09:59 2023 -0800

    Commented hardcoded arch

commit 94056df
Merge: c222dcc 38c19ba
Author: Ramon Wang <[email protected]>
Date:   Thu Jan 26 13:11:49 2023 -0800

    Merge branch 'main' of https://github.com/data-science-ucsb/gauchocourses

commit c222dcc
Author: Ramon Wang <[email protected]>
Date:   Thu Jan 26 13:10:59 2023 -0800

    Refactored to work with MongoDB

commit a2a813e
Author: Noah Wang <[email protected]>
Date:   Thu Jan 26 11:11:27 2023 -0800

    Added logout button

commit 38c19ba
Merge: a1e9b73 c6fa45e
Author: Winbert Zhang <[email protected]>
Date:   Wed Jan 25 21:17:21 2023 -0800

    Merge pull request #37 from data-science-ucsb/fix-npm-run-dev

    Updates Lombok to version 1.18.22 as it was causing an error with npm run dev

commit a1e9b73
Merge: d588658 48eea3b
Author: Winbert Zhang <[email protected]>
Date:   Wed Jan 25 20:52:45 2023 -0800

    Merge pull request #30 from Ponmo/main

    Fixed: course-search-results now does not block out course-selectors

commit c6fa45e
Author: Noah Wang <[email protected]>
Date:   Wed Jan 25 20:49:39 2023 -0800

    Updates Lombok to version 1.18.22 as it was causing an error with npm run dev

commit 48eea3b
Author: Noah Wang <[email protected]>
Date:   Tue Jan 17 20:29:23 2023 -0800

    initial commit

commit b241bcb
Author: Steven Choi <[email protected]>
Date:   Sat Jan 14 18:20:48 2023 -0800

    removed var in application.properties

commit 4bee445
Author: IrenaW2 <[email protected]>
Date:   Wed Jan 4 17:25:38 2023 -0800

    Issue 4: Build/push docker image to github container registry (#26)

commit fef71ca
Author: Ethan Yuan <[email protected]>
Date:   Thu Jan 12 22:19:57 2023 -0800

    func checks both classSection and customEvents

commit 4eca6d4
Author: Ethan Yuan <[email protected]>
Date:   Tue Jan 10 14:03:04 2023 -0800

    condition watching section vuex state

commit 00481b3
Author: Steven Choi <[email protected]>
Date:   Wed Jan 4 19:21:59 2023 -0800

    pr

commit b839538
Author: Steven Choi <[email protected]>
Date:   Thu Dec 29 16:08:14 2022 -0800

    displays schedule count next to day

commit 88381f0
Author: Steven Choi <[email protected]>
Date:   Tue Dec 20 18:20:08 2022 -0800

    now pops up with error if no section is selected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JasonFreeberg JasonFreeberg JasonFreeberg approved these changes

@WinbertZhang WinbertZhang Awaiting requested review from WinbertZhang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@phamrachel17 @WinbertZhang @JasonFreeberg