Skip to content

mark deprecated method and fix unreachable exception #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2025

Conversation

wayne-pq
Copy link
Contributor

1.mark deprecated method(getBigDecimal with scale, getUnicodeStream), provide migration example and test cases.
2.do not use end-of-line comments.
3.fix unreachable exception(DatabendConnection#1135).

…provide migration example and test cases.

2.Do not use end-of-line comments.
3.fix unreachable exception(DatabendConnection#1135).

Signed-off-by: wayne <[email protected]>
Copy link
Member

@hantmac hantmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! LGTM

@hantmac hantmac merged commit 08f34e3 into databendlabs:main Jun 23, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants