-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Add databricks_function
resource
#4189
base: main
Are you sure you want to change the base?
Conversation
…source updating feature branch.
databricks_function
resourcedatabricks_function
resource
databricks_function
resourcedatabricks_function
resource
Hello, is there any timeline on when this could make it into the provider? Would love to have this soon! |
Hi @ian-norris-ncino. I'm aiming to have this integrated into the provider by the end of the month, depending on my availability. I'll keep you posted. |
databricks_function
resourcedatabricks_function
resource
docs/resources/function.md
Outdated
name = "calculate_bmi" | ||
catalog_name = databricks_catalog.sandbox.name | ||
schema_name = databricks_schema.functions.name | ||
input_params = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It could be easier for people to specify input_param
as separate blocks, like we do in other resources
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although doc says that input_params
is a block, and then there are parameters inside: https://docs.databricks.com/api/workspace/functions/create#input_params
Test Details: go/deco-tests/11869831592 |
internal/providers/pluginfw/resources/catalog/resource_function.go
Outdated
Show resolved
Hide resolved
internal/providers/pluginfw/resources/catalog/resource_function.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @dgomez04, thanks for the PR, left some comments.
internal/providers/pluginfw/resources/catalog/resource_function.go
Outdated
Show resolved
Hide resolved
internal/providers/pluginfw/resources/catalog/resource_function.go
Outdated
Show resolved
Hide resolved
internal/providers/pluginfw/resources/catalog/resource_function.go
Outdated
Show resolved
Hide resolved
internal/providers/pluginfw/resources/catalog/resource_function.go
Outdated
Show resolved
Hide resolved
internal/providers/pluginfw/resources/catalog/resource_function_acc_test.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking nice! Some changes needed for the next iteration, but I think we're not far from the final state.
internal/providers/pluginfw/products/catalog/resource_function.go
Outdated
Show resolved
Hide resolved
c.SetRequired("name") | ||
c.SetRequired("catalog_name") | ||
c.SetRequired("schema_name") | ||
c.SetRequired("input_params") | ||
c.SetRequired("data_type") | ||
c.SetRequired("full_data_type") | ||
c.SetRequired("routine_defintion") | ||
c.SetRequired("is_deterministic") | ||
c.SetRequired("is_null_call") | ||
c.SetRequired("specific_name") | ||
c.SetRequired("routine_body") | ||
c.SetRequired("security_type") | ||
c.SetRequired("sql_data_access") | ||
c.SetRequired("parameter_style") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these actually needed? As in, if you don't have them, are they treated as optional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I based myself on the REST API reference, did I interpret it correctly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If they are in the REST API reference, they are in our API specification. It's probable that ResourceStructToSchema() generates a schema with these already set. You can verify by seeing that we don't specify these fields as optional in the TFSDK structs:
// Function parameter style. **S** is the value for SQL.
ParameterStyle types.String `tfsdk:"parameter_style" tf:""
So yes, anything that is marked properly in the OpenAPI spec can be removed from here.
internal/providers/pluginfw/products/catalog/resource_function.go
Outdated
Show resolved
Hide resolved
c.SetReadOnly("updated_at") | ||
c.SetReadOnly("updated_by") | ||
|
||
return c |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked at UpdateFunction, and it seems like the only thing you can update about a function is its owner. Everything else cannot be updated. Can we mark all other fields with SetForceNew()
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SetForceNew()
doesn't seem to be a method of tfschema.CustomizableSchema
. Am I looking at the wrong place? Any guidance here appreciate it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My mistake, that is how you did this with SDKv2. This is now done via plan modifiers. For example:
import "github.com/hashicorp/terraform-plugin-framework/resource/schema/stringplanmodifier"
...
cs.AddPlanModifier(stringplanmodifier.RequiresReplace(), "name")
You can interpret this as: when computing the plan, if there is a change to the "name" field, the entire resource must be replaced.
Do this for each field that cannot be updated.
…s at the resource level
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
Changes
Introduces
databricks_function
resource—allowing users to create and manage UDFs within Terraform. work in progress...Closes #4074
Tests
make test
run locallydocs/
folderinternal/acceptance