Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Send only what is required in Update of databricks_credential #4349

Merged
merged 5 commits into from
Jan 7, 2025
Merged

[Fix] Send only what is required in Update of databricks_credential #4349

merged 5 commits into from
Jan 7, 2025

Conversation

alexott
Copy link
Contributor

@alexott alexott commented Dec 24, 2024 •
edited
Loading

Changes

This is a workaround for a problem in the API spec - right now, the Update operation tries to send the full struct, although the API accepts only one attribute of that struct. For GCP we should omit the struct completely...

The problem doesn't exist for storage_credential on AWS as it uses the correct structure for the Update request, but problem exists for GCP.

Resolves #4335

Tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • using Go SDK
  • using TF Plugin Framework

@alexott alexott requested review from a team as code owners December 24, 2024 12:32
@alexott alexott requested review from hectorcast-db and removed request for a team December 24, 2024 12:32
@eng-dev-ecosystem-bot
Copy link
Collaborator

Test Details: go/deco-tests/12481744402

@alexott alexott temporarily deployed to test-trigger-is January 7, 2025 08:21 — with GitHub Actions Inactive
@alexott alexott temporarily deployed to test-trigger-is January 7, 2025 08:22 — with GitHub Actions Inactive
@alexott alexott temporarily deployed to test-trigger-is January 7, 2025 10:49 — with GitHub Actions Inactive
@alexott alexott temporarily deployed to test-trigger-is January 7, 2025 10:50 — with GitHub Actions Inactive
@alexott alexott temporarily deployed to test-trigger-is January 7, 2025 11:27 — with GitHub Actions Inactive
@alexott alexott temporarily deployed to test-trigger-is January 7, 2025 11:29 — with GitHub Actions Inactive
@alexott alexott temporarily deployed to test-trigger-is January 7, 2025 11:35 — with GitHub Actions Inactive
@alexott alexott temporarily deployed to test-trigger-is January 7, 2025 11:36 — with GitHub Actions Inactive
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 7, 2025

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/terraform

Inputs:

  • PR number: 4349
  • Commit SHA: a324df55bee10044e4db8e0d47ac1f793279575c

Checks will be approved automatically on success.

mgyucht
mgyucht approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@mgyucht mgyucht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great bias for action!

mgyucht
mgyucht approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@mgyucht mgyucht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great bias for action!

@alexott alexott added this pull request to the merge queue Jan 7, 2025
Merged via the queue into main with commit 01b63ac Jan 7, 2025
14 checks passed
@alexott alexott deleted the issue-4335 branch January 7, 2025 16:14
tanmay-db added a commit that referenced this pull request Jan 15, 2025
@tanmay-db
[Release] Release v1.63.0
740e581 
### New Features and Improvements

 * Add `fallback` to `databricks_external_location` ([#4372](#4372)).

### Bug Fixes

 * Send only what is required in Update of `databricks_credential` ([#4349](#4349)).

### Documentation

 * Add `MANAGE` privilege to the relevant UC resources ([#4371](#4371)).
 * Add a note about schema evolution and `databricks_sql_table` ([#4352](#4352)).
 * Add description of `clean_rooms_notebook_task` in `databricks_job` ([#4368](#4368)).
 * Add docs for cluster attributes for clusters assigned to groups ([#4359](#4359)).
 * Add note about use of `azurerm_databricks` for enhanced security settings ([#4393](#4393)).
 * Clarify views sharing in `databricks_share` ([#4378](#4378)).
 * Document job edit_mode ([#4354](#4354)).

### Internal Changes

 * Auto generated customizable schemas ([#4356](#4356)).
 * Disable `terraform fmt` in exporter to workaround build issues ([#4394](#4394)).
 * Fixed redundant optional owners in share resource and bumped Go SDK ([#4396](#4396)).
 * Load auto-generated resources and data sources ([#4367](#4367)).
 * Migrate workflows that need write access to use hosted runners ([#4377](#4377)).
 * Remove TF annotations on TFSDK models ([#4383](#4383)).
 * Restart Cluster before Library Installation ([#4384](#4384)).

### Dependency Updates

 * Bump github.com/zclconf/go-cty from 1.15.1 to 1.16.0 ([#4374](#4374)).
 * Bump github.com/zclconf/go-cty from 1.16.0 to 1.16.1 ([#4397](#4397)).

### Exporter

 * Add exporting of `for_each_task` in jobs ([#4347](#4347)).
 * Add references for missing permissions/grants types ([#4390](#4390)).
 * Support for group assigned clusters ([#4361](#4361)).
 * Use Go SDK to list clusters ([#4385](#4385)).
 * Use `Workspace.Export` from Go SDK for notebooks/files ([#4391](#4391)).
@tanmay-db tanmay-db mentioned this pull request Jan 15, 2025
Merged
github-merge-queue bot pushed a commit that referenced this pull request Jan 16, 2025
@tanmay-db
[Release] Release v1.63.0 (#4400)
70ac668 
### New Features and Improvements

* Add `fallback` to `databricks_external_location`
([#4372](#4372)).


### Bug Fixes

* Send only what is required in Update of `databricks_credential`
([#4349](#4349)).


### Documentation

* Add `MANAGE` privilege to the relevant UC resources
([#4371](#4371)).
* Add a note about schema evolution and `databricks_sql_table`
([#4352](#4352)).
* Add description of `clean_rooms_notebook_task` in `databricks_job`
([#4368](#4368)).
* Add docs for cluster attributes for clusters assigned to groups
([#4359](#4359)).
* Add note about use of `azurerm_databricks` for enhanced security
settings
([#4393](#4393)).
* Clarify views sharing in `databricks_share`
([#4378](#4378)).
* Document job edit_mode
([#4354](#4354)).


### Internal Changes

* Auto generated customizable schemas
([#4356](#4356)).
* Disable `terraform fmt` in exporter to workaround build issues
([#4394](#4394)).
* Fixed redundant optional owners in share resource and bumped Go SDK
([#4396](#4396)).
* Load auto-generated resources and data sources
([#4367](#4367)).
* Migrate workflows that need write access to use hosted runners
([#4377](#4377)).
* Remove TF annotations on TFSDK models
([#4383](#4383)).
* Restart Cluster before Library Installation
([#4384](#4384)).


### Dependency Updates

* Bump github.com/zclconf/go-cty from 1.15.1 to 1.16.0
([#4374](#4374)).
* Bump github.com/zclconf/go-cty from 1.16.0 to 1.16.1
([#4397](#4397)).


### Exporter

* Add exporting of `for_each_task` in jobs
([#4347](#4347)).
* Add references for missing permissions/grants types
([#4390](#4390)).
* Support for group assigned clusters
([#4361](#4361)).
* Use Go SDK to list clusters
([#4385](#4385)).
* Use `Workspace.Export` from Go SDK for notebooks/files
([#4391](#4391)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgyucht mgyucht mgyucht approved these changes

@hectorcast-db hectorcast-db Awaiting requested review from hectorcast-db hectorcast-db is a code owner automatically assigned from databricks/eng-plat-auto-exp-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ISSUE] Issue with databricks_credential resource: unable to modify
3 participants
@alexott @eng-dev-ecosystem-bot @mgyucht