[Internal] Auto generated customizable schemas #4356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauchy
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
rauchy
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
rauchy
force-pushed
the
auto-generated-customizable-schemas
branch
from
d95518b to
8382d47
Compare
rauchy
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
rauchy
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
rauchy
force-pushed
the
auto-generated-customizable-schemas
branch
from
8382d47 to
a0c1e9a
Compare
rauchy
force-pushed
the
auto-generated-customizable-schemas
branch
from
a0c1e9a to
aa7c04a
Compare
rauchy
force-pushed
the
auto-generated-customizable-schemas
branch
from
aa7c04a to
69bc26b
Compare
rauchy
force-pushed
the
auto-generated-customizable-schemas
branch
from
69bc26b to
99b65de
Compare
mgyucht
reviewed
Jan 2, 2025
Comment on lines
201
to
203
| if schemaProvider, ok := v.(CustomizableSchemaProvider); ok { | ||
| cs = schemaProvider.ToSchema(cs) | ||
| } |
There was a problem hiding this comment.
This should be raised out of this if block.
| @@ -185,7 +197,11 @@ func ResourceStructToSchemaMap(ctx context.Context, v any, customizeSchema func( | |||
| nestedBlockObj := typeToSchema(ctx, reflect.ValueOf(v)) | |||
|
|
|||
| if customizeSchema != nil { | |||
| cs := customizeSchema(*ConstructCustomizableSchema(nestedBlockObj)) | |||
| cs := *ConstructCustomizableSchema(nestedBlockObj) | |||
There was a problem hiding this comment.
Also needs to be called on corresponding data source methods.
rauchy
force-pushed
the
auto-generated-customizable-schemas
branch
from
99b65de to
936f841
Compare
|
Test Details: go/deco-tests/12596325628 |
mgyucht
approved these changes
Jan 3, 2025
| @@ -17,6 +17,10 @@ import ( | |||
| "github.com/hashicorp/terraform-plugin-framework/types" | |||
| ) | |||
|
|
|||
| type CustomizableSchemaProvider interface { | |||
rauchy
force-pushed
the
auto-generated-customizable-schemas
branch
from
1315b04 to
59a31c6
Compare
rauchy
force-pushed
the
auto-generated-customizable-schemas
branch
from
59a31c6 to
6e206f9
Compare
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Tests
make testrun locallydocs/folderinternal/acceptance