Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Internal] Fixed redundant optional owners in share resource and bumped Go SDK #4396

Merged
merged 4 commits into from
Jan 15, 2025
Merged

[Internal] Fixed redundant optional owners in share resource and bumped Go SDK #4396

merged 4 commits into from
Jan 15, 2025

Conversation

tanmay-db
Copy link
Contributor

@tanmay-db tanmay-db commented Jan 14, 2025 •
edited
Loading

Changes

Tests

CI

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • using Go SDK
  • using TF Plugin Framework

@tanmay-db tanmay-db marked this pull request as ready for review January 14, 2025 15:59
@tanmay-db tanmay-db requested review from a team as code owners January 14, 2025 15:59
@tanmay-db tanmay-db requested review from rauchy and removed request for a team January 14, 2025 15:59
@tanmay-db tanmay-db changed the title [Internal] Bump Go SDK and use config/credentials [Internal] Bump Go SDK, regenerate TF structs and use config/credentials package name Jan 14, 2025
@alexott
Copy link
Contributor

alexott commented Jan 14, 2025

We'll need to have a follow-up PR to add run_as to DLT pipelines.

@tanmay-db
Copy link
Contributor Author

We'll need to have a follow-up PR to add run_as to DLT pipelines.

Hi @alexott, is this a new feature request or some regression?

@alexott
Copy link
Contributor

alexott commented Jan 15, 2025

@tanmay-db it's more a feature request as DLT is starting to support run_as similar to the jobs

@tanmay-db
Copy link
Contributor Author

I see, I think it doesn't have to be a blocker for the next release because we need to release the TF as soon as possible since it is blocking DABS release for databricks apps which is being aimed to be released this week. Just to check is there a ticket for this?

@alexott
Copy link
Contributor

alexott commented Jan 15, 2025

No, it's not a blocker. I'll create GH issue to track it separately

@tanmay-db
Copy link
Contributor Author

No, it's not a blocker. I'll create GH issue to track it separately

Thank you @alexott

@tanmay-db tanmay-db changed the title [Internal] Bump Go SDK, regenerate TF structs and use config/credentials package name [Internal] Fixed redundant optional owners in share resource and bumped Go SDK Jan 15, 2025
@github-actions GitHub Actions
Copy link

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/terraform

Inputs:

  • PR number: 4396
  • Commit SHA: 6f386f6617e5b0ef648349932a66b5515d95f8e8

Checks will be approved automatically on success.

tanmay-db
tanmay-db commented Jan 15, 2025
View reviewed changes
internal/service/sharing_tf/model.go
}

func (c UpdateShare) ApplySchemaCustomizations(attrs map[string]tfschema.AttributeBuilder) map[string]tfschema.AttributeBuilder {
attrs["comment"] = attrs["comment"].SetOptional()
attrs["name"] = attrs["name"].SetRequired()
attrs["new_name"] = attrs["new_name"].SetOptional()
attrs["owner"] = attrs["owner"].SetComputed()
attrs["effective_owner"] = attrs["effective_owner"].SetComputed()
attrs["owner"] = attrs["owner"].SetOptional()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

highlight

@tanmay-db tanmay-db added this pull request to the merge queue Jan 15, 2025
Merged via the queue into main with commit 1f7c015 Jan 15, 2025
12 checks passed
@tanmay-db tanmay-db deleted the go-sdk-bump branch January 15, 2025 15:16
tanmay-db added a commit that referenced this pull request Jan 15, 2025
@tanmay-db
[Release] Release v1.63.0
740e581 
### New Features and Improvements

 * Add `fallback` to `databricks_external_location` ([#4372](#4372)).

### Bug Fixes

 * Send only what is required in Update of `databricks_credential` ([#4349](#4349)).

### Documentation

 * Add `MANAGE` privilege to the relevant UC resources ([#4371](#4371)).
 * Add a note about schema evolution and `databricks_sql_table` ([#4352](#4352)).
 * Add description of `clean_rooms_notebook_task` in `databricks_job` ([#4368](#4368)).
 * Add docs for cluster attributes for clusters assigned to groups ([#4359](#4359)).
 * Add note about use of `azurerm_databricks` for enhanced security settings ([#4393](#4393)).
 * Clarify views sharing in `databricks_share` ([#4378](#4378)).
 * Document job edit_mode ([#4354](#4354)).

### Internal Changes

 * Auto generated customizable schemas ([#4356](#4356)).
 * Disable `terraform fmt` in exporter to workaround build issues ([#4394](#4394)).
 * Fixed redundant optional owners in share resource and bumped Go SDK ([#4396](#4396)).
 * Load auto-generated resources and data sources ([#4367](#4367)).
 * Migrate workflows that need write access to use hosted runners ([#4377](#4377)).
 * Remove TF annotations on TFSDK models ([#4383](#4383)).
 * Restart Cluster before Library Installation ([#4384](#4384)).

### Dependency Updates

 * Bump github.com/zclconf/go-cty from 1.15.1 to 1.16.0 ([#4374](#4374)).
 * Bump github.com/zclconf/go-cty from 1.16.0 to 1.16.1 ([#4397](#4397)).

### Exporter

 * Add exporting of `for_each_task` in jobs ([#4347](#4347)).
 * Add references for missing permissions/grants types ([#4390](#4390)).
 * Support for group assigned clusters ([#4361](#4361)).
 * Use Go SDK to list clusters ([#4385](#4385)).
 * Use `Workspace.Export` from Go SDK for notebooks/files ([#4391](#4391)).
@tanmay-db tanmay-db mentioned this pull request Jan 15, 2025
Merged
github-merge-queue bot pushed a commit that referenced this pull request Jan 16, 2025
@tanmay-db
[Release] Release v1.63.0 (#4400)
70ac668 
### New Features and Improvements

* Add `fallback` to `databricks_external_location`
([#4372](#4372)).


### Bug Fixes

* Send only what is required in Update of `databricks_credential`
([#4349](#4349)).


### Documentation

* Add `MANAGE` privilege to the relevant UC resources
([#4371](#4371)).
* Add a note about schema evolution and `databricks_sql_table`
([#4352](#4352)).
* Add description of `clean_rooms_notebook_task` in `databricks_job`
([#4368](#4368)).
* Add docs for cluster attributes for clusters assigned to groups
([#4359](#4359)).
* Add note about use of `azurerm_databricks` for enhanced security
settings
([#4393](#4393)).
* Clarify views sharing in `databricks_share`
([#4378](#4378)).
* Document job edit_mode
([#4354](#4354)).


### Internal Changes

* Auto generated customizable schemas
([#4356](#4356)).
* Disable `terraform fmt` in exporter to workaround build issues
([#4394](#4394)).
* Fixed redundant optional owners in share resource and bumped Go SDK
([#4396](#4396)).
* Load auto-generated resources and data sources
([#4367](#4367)).
* Migrate workflows that need write access to use hosted runners
([#4377](#4377)).
* Remove TF annotations on TFSDK models
([#4383](#4383)).
* Restart Cluster before Library Installation
([#4384](#4384)).


### Dependency Updates

* Bump github.com/zclconf/go-cty from 1.15.1 to 1.16.0
([#4374](#4374)).
* Bump github.com/zclconf/go-cty from 1.16.0 to 1.16.1
([#4397](#4397)).


### Exporter

* Add exporting of `for_each_task` in jobs
([#4347](#4347)).
* Add references for missing permissions/grants types
([#4390](#4390)).
* Support for group assigned clusters
([#4361](#4361)).
* Use Go SDK to list clusters
([#4385](#4385)).
* Use `Workspace.Export` from Go SDK for notebooks/files
([#4391](#4391)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexott alexott alexott approved these changes

@rauchy rauchy Awaiting requested review from rauchy rauchy is a code owner automatically assigned from databricks/eng-plat-auto-exp-reviewers

@mgyucht mgyucht Awaiting requested review from mgyucht

@andrewnester andrewnester Awaiting requested review from andrewnester

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tanmay-db @alexott