Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Exporter] improve handling of Emit/Add operations under the heavy load #4401

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Exporter] improve handling of Emit/Add operations under the heavy load #4401

wants to merge 1 commit into from

Conversation

alexott
Copy link
Contributor

@alexott alexott commented Jan 16, 2025

Changes

We may still have (theoretically) a race condition in Add/Emit operations due to the checks performed in separate functions, not directly in corresponding functions. This PR should prevent that theoretical possibility.

Tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • using Go SDK
  • using TF Plugin Framework

@alexott
[Exporter] improve handling of Emit/Add operations under the heavy load
f4a8eab 
We may still have (theoretically) a race condition in `Add`/`Emit` operations due to the
checks performed in separate functions, not directly in corresponding functions.  This PR
should prevent that theoretical possibility.
@alexott alexott requested review from a team as code owners January 16, 2025 07:51
@alexott alexott requested review from tanmay-db and removed request for a team January 16, 2025 07:51
@alexott alexott temporarily deployed to test-trigger-is January 16, 2025 07:51 — with GitHub Actions Inactive
@github-actions GitHub Actions
Copy link

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/terraform

Inputs:

  • PR number: 4401
  • Commit SHA: f4a8eab5b7eb3ffd369c6069ec4c21bb6e33bb47

Checks will be approved automatically on success.

@alexott alexott temporarily deployed to test-trigger-is January 16, 2025 07:52 — with GitHub Actions Inactive
@alexott alexott added the exporter TF configuration generator label Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanmay-db tanmay-db Awaiting requested review from tanmay-db tanmay-db is a code owner automatically assigned from databricks/eng-plat-auto-exp-reviewers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
exporter TF configuration generator
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@alexott