Update scroll to be an unsigned int #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scroll needs to be an unsigned integer... otherwise, it'll roll over to a negative value and 'wreak havoc' when updating the LED array in the subsequent loop. On a 32-bit processor, the int value will range from +2^31-1 top -2^31, so the rollover won't occur for a LONG time. However, on a number of Arduino platforms, the int value will only be 16-bits... so it'll roll at 32K iterations. (I commented in the YouTube video but decided to come here as well to propose the change.) Cheers, Dave
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scroll needs to be an unsigned integer... otherwise, it'll roll over to a negative value and 'wreak havoc' when updating the LED array in the subsequent loop. On a 32-bit processor, the int value will range from +2^31-1 top -2^31, so the rollover won't occur for a LONG time. However, on a number of Arduino platforms, the int value will only be 16-bits... so it'll roll at 32K iterations.
(I commented in the YouTube video but decided to come here as well to propose the change.)
Cheers,
Dave