Refactor/fix: rework server to send a response back and run rest of command work async #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhouweling
force-pushed
the
debug-worker-not-functioning
branch
from
20c5ab3 to
030de46
Compare
davidhouweling
force-pushed
the
main
branch
2 times, most recently
from
4245444 to
fbe5508
Compare
davidhouweling
force-pushed
the
debug-worker-not-functioning
branch
2 times, most recently
from
65369b9 to
aa1a051
Compare
davidhouweling
force-pushed
the
debug-worker-not-functioning
branch
3 times, most recently
from
3a46abf to
f6fc716
Compare
davidhouweling
force-pushed
the
debug-worker-not-functioning
branch
from
f6fc716 to
1daec86
Compare
davidhouweling
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
In testing the previous implementation built for Cloudflare, requests from Discord were being cancelled.
After some digging around, I found that there is a worker context
waitForwhich allows for workers to continue working even after responding.Using this knowledge which is what I would have loved to have known before, I have reworked the approach so that the Discord request receives an immediate response (i.e. acknowledgement) and then subsequently updating the message.