Grants #98
Merged
Grants #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What a guy! |
|
@dave-connors-3 now that #94 is merged, there's some conflicts sorry! |
|
@joellabes hit me with that sweet sweet review |
joellabes
previously approved these changes
Oct 31, 2023
schemas/1.5/dbt_project-1.5.json
Outdated
| @@ -818,6 +830,16 @@ | |||
| "additionalProperties": false | |||
| } | |||
| }, | |||
| "grants": { | |||
| "type": "object", | |||
| "description": "flexible grant config. accepts any string key, expects a string or list of strings value", | |||
There was a problem hiding this comment.
The various IDEs should take responsibility for saying what the type is. The description would be better if it was what the strings actually are (what is granted, to whom it is granted)
joellabes
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #97
only for you @dpguthrie