Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Migrate license map resource from SDKv2 to plugin framework #325

Merged
merged 3 commits into from
Dec 19, 2024

Conversation

csquire
Copy link
Contributor

@csquire csquire commented Dec 12, 2024

Migrates the dbtcloud_license_map resource from the legacy SDKv2 to the Terraform Plugin Framework.

@csquire csquire requested a review from chasewalden December 12, 2024 23:32
@csquire csquire force-pushed the migrate-license-map-resource branch from fd5c79b to b2489ca Compare December 17, 2024 17:14
Copy link
Collaborator

@chasewalden chasewalden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. Want to check in on the datatype change on id, but otherwise I am happy to approve once we can touch base on that.

docs/resources/license_map.md Show resolved Hide resolved
@chasewalden chasewalden merged commit 8c2938c into dbt-labs:main Dec 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants