🔥 zb: Drop windows-gdbus feature & support autolaunch address unconditionally
#729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the one from std instead.
zeenix
force-pushed
the
drop-windows-gdbus-feat
branch
7 times, most recently
from
dfa03ef
to
344921f
Compare
Turns out that the reference dbus implementation supports autolaunch fine and we don't need gdbus binary or special support for it. Hopefully, in the near future, busd will also support it. This commit drops the `windows-gdbus` feature. This means we're no longer compatible with gdbus binary but that's not our fault that it can't handle handshake pipelining. I seriously doubt anyone uses this anyway. Fixes dbus2#687.
We no longer need it.
They're no longer needed.
zeenix
force-pushed
the
drop-windows-gdbus-feat
branch
from
344921f
to
29b9faf
Compare
zeenix
changed the title
windows-gdbus featurewindows-gdbus feature & support autolaunch address unconditionally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out that the reference dbus implementation supports autolaunch fine and we don't need gdbus binary or special support for it. Hopefully, in the near future, busd will also support it.
This PR drops the
windows-gdbusfeature. This means we're no longer compatible with gdbus binary but that's not our fault that it can't handle handshake pipelining. I seriously doubt anyone uses this anyway.Fixes #687.