Show error codes

ddbj · Jun 11, 2024 · e50b7ad · e50b7ad
1 parent 63b5243
commit e50b7ad
Show file tree

Hide file tree

Showing 6 changed files with 11 additions and 10 deletions.
diff --git a/api/app/models/ddbj_validator.rb b/api/app/models/ddbj_validator.rb
@@ -22,8 +22,9 @@ def validate(validation)
 
           obj.update! validity:, validation_details: details.fetch(:messages).map {|msg|
             {
-              **msg.slice(:id, :message),
-              severity: msg.fetch(:level)
+              code:     msg[:id],
+              severity: msg[:level],
+              message:  msg[:message]
             }
           }
         end

diff --git a/schema/openapi.d.ts b/schema/openapi.d.ts
@@ -289,7 +289,7 @@ export interface components {
       /** @enum {string|null} */
       validity: "valid" | "invalid" | "error" | null;
       details: {
-          id: string;
+          code: string;
           severity: string;
           message: string;
         }[] | null;

diff --git a/schema/openapi.yml b/schema/openapi.yml
@@ -733,10 +733,10 @@ components:
           items:
             type: object
             additionalProperties: false
-            required: [id, severity, message]
+            required: [code, severity, message]
 
             properties:
-              id:
+              code:
                 type: string
 
               severity:

diff --git a/schema/openapi.yml.erb b/schema/openapi.yml.erb
@@ -691,10 +691,10 @@ components:
           items:
             type: object
             additionalProperties: false
-            required: [id, severity, message]
+            required: [code, severity, message]
 
             properties:
-              id:
+              code:
                 type: string
 
               severity:

diff --git a/schema/package.json b/schema/package.json
@@ -3,5 +3,5 @@
     "openapi-typescript": "^6.7.6",
     "quicktype": "^23.0.170"
   },
-  "packageManager": "pnpm@9.1.4"
+  "packageManager": "pnpm@9.2.0"
 }
diff --git a/web/app/components/validation.gts b/web/app/components/validation.gts
@@ -155,7 +155,7 @@ export default class ValidationComponent extends Component<Signature> {
                 <table class='table m-0'>
                   <thead>
                     <tr>
-                      <th>ID</th>
+                      <th>Code</th>
                       <th>Severity</th>
                       <th>Message</th>
                     </tr>
@@ -165,7 +165,7 @@ export default class ValidationComponent extends Component<Signature> {
                     {{#each result.details as |detail i|}}
                       <tr>
                         {{#let (eq i (sub (array result.details.length 1))) as |isLast|}}
-                          <td class={{if isLast 'border-bottom-0'}}>{{if detail.id detail.id '-'}}</td>
+                          <td class={{if isLast 'border-bottom-0'}}>{{if detail.code detail.code '-'}}</td>
                           <td class={{if isLast 'border-bottom-0'}}>{{if detail.severity detail.severity '-'}}</td>
                           <td class={{if isLast 'border-bottom-0'}}>{{detail.message}}</td>
                         {{/let}}