Allow initial RecordsWrite without data to be written to the DWN. #629
+496
−302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #629 +/- ##
==========================================
- Coverage 98.57% 98.42% -0.15%
==========================================
Files 68 68
Lines 8417 8402 -15
Branches 1227 1227
==========================================
- Hits 8297 8270 -27
- Misses 114 124 +10
- Partials 6 8 +2 ☔ View full report in Codecov by Sentry. |
LiranCohen
commented
Nov 30, 2023
LiranCohen
requested review from
mistermoe,
csuwildcat and
thehenrytsai
as code owners
There was a problem hiding this comment.
Added some comments, and sent a PR to address some of the comments:
#635
…ePrunedInitialRecordsWrite method
LiranCohen
force-pushed
the
lirancohen/write-initial-without-data
branch
from
597d40b to
ab170bf
Compare
|
Love the refactor and comments, having the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some cases where a DWN might have an initial
RecordsWritemessage used to create a record, but not have the data associated with it.Until now this was only possible through a special method on the DWN
synchronizePrunedInitialRecordsWritewhich was only used for sync. However, there are multi-participant scenarios where this same behavior is necessary.This PR exposes that functionality to the general processing of
RecordsWritemessages.If a
RecordsWritemessage is supplied without any data, it is checked that it is the initialRecordsWriteand indexes it as not being the latest state, this prevents it from being queryable without any data until a subsequentRecordsWritewith data is available.Addresses: #628