Read & Query HTTP APIs - Part 2

[csuwildcat]

No description provided.

[LiranCohen]

Looks good, just a question regarding returning 404 instead of 401.

[thehenrytsai]

Looks good, made a bunch of refactoring. Only tests is left to bring new code coverage up.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 84.04255% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 94.07%. Comparing base (3873d9f) to head (a678d06).
Report is 6 commits behind head on main.

Files	Patch %	Lines
src/http-api.ts	84.04%	15 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #129      +/-   ##
==========================================
- Coverage   94.43%   94.07%   -0.37%     
==========================================
  Files          25       25              
  Lines        2247     2362     +115     
  Branches      299      315      +16     
==========================================
+ Hits         2122     2222     +100     
- Misses        124      139      +15     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[csuwildcat]

Let's just merge it

[LiranCohen]

After adding some tests this is in a good place.

Once decentralized-identity/dwn-sdk-js#739 is complete, we can clean up some of this code that does a RecordsQuery followed by a RecordsRead with only the RecordsRead.

This will also allow us to clean up some of the potentially unreachable codepaths in place today.

[thehenrytsai]

A send-it approval, given the amount of tests that were added.

🐐 @LiranCohen.