Skip to content

Commit

Permalink
fix: Add semi-require "webhook-type" to slack actions
Browse files Browse the repository at this point in the history
Our slack actions appear to be workflows, except for the image notify
step, which is an app with an incoming webhook - assigned the
webhook-trigger accordingly.

Also added build summary URLs for nightly check and publish.

Follow-up #6384
  • Loading branch information
niloc132 committed Jan 17, 2025
1 parent 475128a commit 5f74320
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 2 deletions.
1 change: 1 addition & 0 deletions .github/workflows/create-docs-issues.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ jobs:
env:
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL_DEVREL }}
with:
webhook-type: webhook-trigger
payload: |
{
"repository": "${{ github.repository }}",
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/nightly-check-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -104,9 +104,10 @@ jobs:
id: slack-nightly-failure
if: ${{ failure() && github.repository_owner == 'deephaven' && github.ref == 'refs/heads/main' }}
with:
webhook-type: webhook-trigger
payload: |
{
"slack_message": "Nightly build failure in ${{ matrix.gradle-task }} on Java ${{ matrix.test-jvm-version }} @ ${{ github.head_ref }} ${{ github.sha }}"
"slack_message": "Nightly build failure in ${{ matrix.gradle-task }} on Java ${{ matrix.test-jvm-version }} @ ${{ github.head_ref }} ${{ github.sha }}" ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}"
}
env:
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_NIGHTLY_FAILURE }}
1 change: 1 addition & 0 deletions .github/workflows/nightly-image-check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,4 +41,5 @@ jobs:
env:
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL_DHC_NOTIFY }}
with:
webhook-type: incoming-webhook
payload: '{"repository": "${{ github.repository }}", "message": "${{ github.workflow }}/${{ github.job }} failure, some image is out of date", "link": "${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}"}'
3 changes: 2 additions & 1 deletion .github/workflows/nightly-publish-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -59,9 +59,10 @@ jobs:
id: slack-nightly-failure
if: failure()
with:
webhook-type: webhook-trigger
payload: |
{
"slack_message": "Nightly publish failure @ ${{ github.head_ref }} ${{ github.sha }}"
"slack_message": "Nightly publish failure @ ${{ github.head_ref }} ${{ github.sha }} ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}"
}
env:
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_NIGHTLY_FAILURE }}

0 comments on commit 5f74320

Please sign in to comment.