Skip to content

Commit

Permalink
Review feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
niloc132 committed Mar 6, 2025
1 parent d0e6dec commit f3c2d06
Showing 1 changed file with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -219,17 +219,17 @@ public JsTreeTable(WorkerConnection workerConnection, JsWidget widget) {
constituentColumns.put(column.getName(), column);
} else {
columns[columns.length] = column;
if (definition.isRollupGroupByColumn() && !definition.isRollupConstituentNodeColumn()) {
if (definition.isRollupGroupByColumn()) {
groupedColumns.push(column);

if (hasConstituentColumns) {
column.setConstituentType(columnDefsByName.get(true).get(definition.getName()).getType());
}
}
if (hasConstituentColumns && definition.getRollupAggregationInputColumn() != null
&& !definition.getRollupAggregationInputColumn().isEmpty()) {
String aggInputCol = definition.getRollupAggregationInputColumn();
if (hasConstituentColumns && aggInputCol != null && !aggInputCol.isEmpty()) {
column.setConstituentType(
columnDefsByName.get(true).get(definition.getRollupAggregationInputColumn()).getType());
columnDefsByName.get(true).get(aggInputCol).getType());
}
}
}
Expand Down

0 comments on commit f3c2d06

Please sign in to comment.