fix: reapply RST_STREAM(cancel) workaround, and disable grpc-timeout #6478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aking JS gRPC client (deephaven#6420)" This reverts commit 7b47794.
niloc132
added
grpc
NoDocumentationNeeded
ReleaseNotesNeeded
niloc132
changed the title
cpwright
approved these changes
Dec 11, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes from #6420 were supposed to be reverted in #6424, but apparently git interpreted the branch's relationship with main differently than I did.
This patch reapplies #6401, with an additional change to avoid noisy stack traces from grpc clients that set
grpc-timeout. At this time, Deephaven doesn't handle timeouts nor do any default clients set timeouts, so the impact here should be minimal.Fixes #5996
See #6400