RerankSorer implementation based on KNN #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
voorhs
requested changes
Nov 25, 2024
|
еще надо добавить этот модуль в серч спейс тестов с оптимизацией и инференсом |
voorhs
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Реализовал RerankScorer. В реализации я попробовал немного порефакторить код поэтому класс наследуется от KNNScorer.
После того как сделал рефакторинг, я понял что не знаю как проверить методы load/dump.
Если вам не понравится мой подход, я могу легко за_copy-paste этот класс как сделано во всех других.
Еще я сначала решил реализовать возможность выбрасывать соседей для которых CrossEncoder дает уверенность меньше заданного порога (rank_threshold_cutoff) но потом осознал:
Тест получился, практически полной копией теста для KNNScorer, тоже кандидат для рефакторинга.