Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/logreg retrieval #81

Merged
merged 60 commits into from
Jan 28, 2025
Merged

Feat/logreg retrieval #81

merged 60 commits into from
Jan 28, 2025

Conversation

Darinochka
Copy link
Collaborator

@Darinochka Darinochka commented Dec 12, 2024

closes #44

@voorhs
Copy link
Collaborator

voorhs commented Dec 22, 2024

closes #44

@Samoed
Copy link
Collaborator

Samoed commented Dec 22, 2024

Closes надо в описании pr писать, чтобы автоматически все закрывалось.

Copy link
Collaborator

@voorhs voorhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

в будущем думаю надо еще подумать над названиями, потому что RetrievalEmbedding и LogRegEmbedding мне перестали нравиться

сейчас мне больше всего нравится идея назвать их RetrievalAimedEmbedding и ClassificationAimedEmbedding

@Darinochka Darinochka requested a review from voorhs January 27, 2025 18:34
Copy link
Collaborator

@voorhs voorhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

супер, ща подтяну dev и сам вмерджу

@voorhs voorhs merged commit 36214e5 into dev Jan 28, 2025
21 checks passed
@Samoed Samoed deleted the feat/logreg-retrieval branch February 10, 2025 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Проблемы с логикой retriever node
3 participants