Sparse vectors representation #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Coverage SummaryDiff against mainResults for commit: 3be5ead Minimum allowed coverage is ♻️ This comment has been updated with latest results |
|
Code Coverage SummaryDiff against mainResults for commit: 43f6011 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
|
Trivy scanning results. |
ludwiktrammer
requested changes
Jan 27, 2025
packages/ragbits-core/src/ragbits/core/embeddings/sparse_vectors.py
Outdated
Show resolved
Hide resolved
packages/ragbits-core/src/ragbits/core/embeddings/sparse_vectors.py
Outdated
Show resolved
Hide resolved
mhordynski
reviewed
Feb 12, 2025
| return f"SparseVector(non_zero_dims={self.non_zero_dims}, non_zero_vals={self.non_zero_vals}, dim={self.dim})" | ||
|
|
||
|
|
||
| class SparseEmbedding(WithConstructionConfig, ABC): |
There was a problem hiding this comment.
It should be plural, to be consistent with our Embeddings class.
There was a problem hiding this comment.
Maybe it's time to rename the Embeddings class itself instead? It doesn't make much sense - it should be Embedder and SparseEmbedder. Even DocumenSearch when it uses the Embeddings instances it calls them embedder (we have multiple occurances of embedder: Embeddings in the code) - because that what it is. "Embeddings" would be an object containing actual embeddings, not a tool for creating them.
There was a problem hiding this comment.
maybe not in this PR but in the one with VectorStore refactor ?
kdziedzic68
force-pushed
the
feature/add_support_to_sparse_vectors
branch
from
b88fafb to
0ef7d8e
Compare
Co-authored-by: Ludwik Trammer <[email protected]>
mhordynski
approved these changes
Feb 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.