feat: audit tracing improvement #378
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Trivy scanning results. |
| @@ -88,7 +88,10 @@ def trace(self, name: str, **inputs: Any) -> Iterator[SimpleNamespace]: # noqa: | |||
| self.stop(outputs=vars(outputs), current_span=span) | |||
|
|
|||
|
|
|||
| def format_attributes(data: dict, prefix: str | None = None) -> dict: | |||
| # TODO: check do we need this method. | |||
There was a problem hiding this comment.
What does this mean? Check how?
There was a problem hiding this comment.
I've checked it. I needed to run the otel tracer and see how the new formater looks like.
I removed this method.
There was a problem hiding this comment.
After discussion I restored the format_attributes the way it was for otel trace handler .
|
|
||
| def shorten_list(lst: list | tuple) -> list: | ||
| """ | ||
| Shortens a list if it's longer than 3 elements. Shortens list elements if it's long string. |
There was a problem hiding this comment.
Suggested change
| Shortens a list if it's longer than 3 elements. Shortens list elements if it's long string. | |
| Shortens a list if it's longer than opt_list_lenght elements. Shortens list elements if it's long string. |
| @@ -119,3 +122,112 @@ def format_attributes(data: dict, prefix: str | None = None) -> dict: | |||
| flattened[current_key] = repr(value) | |||
|
|
|||
| return flattened | |||
|
|
|||
|
|
|||
| def format_attributes(data: dict, prefix: str | None = None) -> dict: | |||
There was a problem hiding this comment.
This function with nested sub-functions that use local variables from the parent function pretty much looks like simulating a class with methods and instance properties. Maybe simply use a class if a class-like functionality is needed?
There was a problem hiding this comment.
I've changed the function to the class
|
Code Coverage SummaryDiff against mainResults for commit: 99800af Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #344