Python 3.11 support dropping 3.7 #926
Merged
+1,315
−1,027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ValerioArnaudo
requested review from
Faylixe,
romi1502,
mmoussallam and
alreadytaikeune
as code owners
added 3 commits
January 24, 2025 08:59
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request title
Description
This PR is meant to allow Spleeter to work with Python 3.11 (3.7 has been discountinued)
How this patch was tested
You tested it, right?
No new code has been added, just some refactoring in order for the unittest to pass for all supported python versions
poetry run pytest tests/poetry run black spleeterDocumentation link and external references
Documentation regarding Str Enum backward compatibility