-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add in-commit timestamp support for change data feed #617
Open
OussamaSaoudi-db
wants to merge
12
commits into
delta-io:main
Choose a base branch
from
OussamaSaoudi-db:cdf_ict_impl
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e2e38cb.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #617 +/- ##
==========================================
+ Coverage 83.45% 83.49% +0.04%
==========================================
Files 74 74
Lines 16877 16931 +54
Branches 16877 16931 +54
==========================================
+ Hits 14084 14137 +53
Misses 2135 2135
- Partials 658 659 +1 ☔ View full report in Codecov by Sentry. |
OussamaSaoudi-db
changed the title
feat: Add in-commit timestamp support for change data fede
feat: Add in-commit timestamp support for change data feed
Jan 2, 2025
scovich
approved these changes
Jan 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, one nit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
This adds support for in-commit timestamps when performing change data feed. Now when a commit contains commitInfo with
inCommitTimestamp
, that timestamp will be the one used for all changed rows in the commit.Depends on #581
Please only review these commits.
How was this change tested?
Add tests to check that the timestamp extracted from commits containing in-commit-timestamps are the ICT instead of file modification time.