Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add in-commit timestamp support for change data feed #617

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

OussamaSaoudi-db
Copy link
Collaborator

@OussamaSaoudi-db OussamaSaoudi-db commented Dec 30, 2024

What changes are proposed in this pull request?

This adds support for in-commit timestamps when performing change data feed. Now when a commit contains commitInfo with inCommitTimestamp, that timestamp will be the one used for all changed rows in the commit.

Depends on #581

Please only review these commits.

How was this change tested?

Add tests to check that the timestamp extracted from commits containing in-commit-timestamps are the ICT instead of file modification time.

Copy link

codecov bot commented Dec 30, 2024

Codecov Report

Attention: Patch coverage is 98.36066% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.49%. Comparing base (c3a868f) to head (da9fe5e).

Files with missing lines Patch % Lines
kernel/src/table_changes/log_replay.rs 91.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #617      +/-   ##
==========================================
+ Coverage   83.45%   83.49%   +0.04%     
==========================================
  Files          74       74              
  Lines       16877    16931      +54     
  Branches    16877    16931      +54     
==========================================
+ Hits        14084    14137      +53     
  Misses       2135     2135              
- Partials      658      659       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@OussamaSaoudi-db OussamaSaoudi-db changed the title feat: Add in-commit timestamp support for change data fede feat: Add in-commit timestamp support for change data feed Jan 2, 2025
Copy link
Collaborator

@scovich scovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one nit

kernel/src/table_changes/log_replay.rs Outdated Show resolved Hide resolved
kernel/src/table_changes/log_replay.rs Outdated Show resolved Hide resolved
kernel/src/table_changes/log_replay.rs Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants