fix: Allow partition value timestamp to be ISO8601 formatted string #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #622 +/- ##
==========================================
+ Coverage 83.45% 83.49% +0.04%
==========================================
Files 74 74
Lines 16877 16919 +42
Branches 16877 16919 +42
==========================================
+ Hits 14084 14127 +43
Misses 2135 2135
+ Partials 658 657 -1 ☔ View full report in Codecov by Sentry. |
|
@zachschuermann The integration test creates a directory |
OussamaSaoudi-db
changed the title
nicklan
approved these changes
Jan 7, 2025
| let mut timestamp = NaiveDateTime::parse_from_str(raw, "%Y-%m-%d %H:%M:%S%.f"); | ||
|
|
||
| if timestamp.is_err() && *self == Timestamp { | ||
| timestamp = NaiveDateTime::parse_from_str(raw, "%+"); |
There was a problem hiding this comment.
Can you add a comment that %+ means "ISO 8601 / RFC 3339 format"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
The delta protocol states that partition value timestamps may be encoded as ISO 8601 formatted strings in addition to the existing format of
{year}-{month}-{day} {hour}:{minute}:{second}. Previously, we did not cover the ISO8601 case.This PR allows kernel to read tables to be partitioned on timestamps with this format.
How was this change tested?
New unit tests are introduces to check the following:
{year}-{month}-{day} {hour}:{minute}:{second}with and without microsecondsA new integration test is also introduced to check a table with timestamp partition values is correctly read.