Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add V2 checkpoint read support integration tests #690

Open
wants to merge 31 commits into
base: main
Choose a base branch
from

Conversation

sebastiantia
Copy link
Collaborator

What changes are proposed in this pull request?

This PR is part of building support for reading V2 checkpoints. #498

This PR ports over existing delta‑spark tests and the tables they create. This test coverage is necessary to ensure that V2 checkpoint files - whether written in JSON or Parquet, with or without sidecars - are read correctly and reliably.

This PR stacks changes on top of #685. For the correct file diff view, please view changes from commit 1ac633b40e48a25e1d1634bc81cbf4f3bc19f90f and onwards.

resolves #671

How was this change tested?

Tables from test-cases of interests in delta-spark's CheckpointSuite have been compressed into .tar.zst archives. They are read by the kernel and the resulting tables are asserted for correctness.

  • v2_checkpoints_json_with_sidecars
  • v2_checkpoints_parquet_with_sidecars
  • v2_checkpoints_json_without_sidecars
  • v2_checkpoints_parquet_without_sidecars
  • v2_classic_checkpoint_json
  • v2_classic_checkpoint_parquet
  • v2_checkpoints_parquet_with_last_checkpoint
  • v2_checkpoints_json_with_last_checkpoint

Copy link

codecov bot commented Feb 12, 2025

Codecov Report

Attention: Patch coverage is 89.66614% with 65 lines in your changes missing coverage. Please review.

Project coverage is 84.29%. Comparing base (eedfd47) to head (972e6d6).

Files with missing lines Patch % Lines
kernel/src/log_segment/tests.rs 88.91% 3 Missing and 51 partials ⚠️
kernel/src/log_segment.rs 90.00% 0 Missing and 9 partials ⚠️
kernel/src/path.rs 66.66% 0 Missing and 1 partial ⚠️
kernel/src/scan/mod.rs 96.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #690      +/-   ##
==========================================
+ Coverage   84.09%   84.29%   +0.19%     
==========================================
  Files          77       77              
  Lines       17805    18398     +593     
  Branches    17805    18398     +593     
==========================================
+ Hits        14973    15508     +535     
+ Misses       2117     2115       -2     
- Partials      715      775      +60     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the breaking-change Change that will require a version bump label Feb 12, 2025
Copy link
Collaborator

@OussamaSaoudi OussamaSaoudi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I'm liking the look of these tests :D Just a quick n light review

kernel/tests/v2_checkpoints.rs Outdated Show resolved Hide resolved
kernel/tests/v2_checkpoints.rs Show resolved Hide resolved
@sebastiantia sebastiantia marked this pull request as ready for review February 12, 2025 18:18
@sebastiantia sebastiantia added merge hold Don't allow the PR to merge and removed breaking-change Change that will require a version bump labels Feb 12, 2025
@github-actions github-actions bot added the breaking-change Change that will require a version bump label Feb 12, 2025
@sebastiantia sebastiantia removed the breaking-change Change that will require a version bump label Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge hold Don't allow the PR to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port over V2 checkpoints delta-spark tests and tables
2 participants