-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: add V2 checkpoint read support integration tests #690
base: main
Are you sure you want to change the base?
tests: add V2 checkpoint read support integration tests #690
Conversation
This reverts commit 3b0b2a0.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #690 +/- ##
==========================================
+ Coverage 84.09% 84.29% +0.19%
==========================================
Files 77 77
Lines 17805 18398 +593
Branches 17805 18398 +593
==========================================
+ Hits 14973 15508 +535
+ Misses 2117 2115 -2
- Partials 715 775 +60 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I'm liking the look of these tests :D Just a quick n light review
What changes are proposed in this pull request?
This PR is part of building support for reading V2 checkpoints. #498
This PR ports over existing delta‑spark tests and the tables they create. This test coverage is necessary to ensure that V2 checkpoint files - whether written in JSON or Parquet, with or without sidecars - are read correctly and reliably.
This PR stacks changes on top of #685. For the correct file diff view, please view changes from commit
1ac633b40e48a25e1d1634bc81cbf4f3bc19f90f
and onwards.resolves #671
How was this change tested?
Tables from test-cases of interests in delta-spark's
CheckpointSuite
have been compressed into.tar.zst
archives. They are read by the kernel and the resulting tables are asserted for correctness.v2_checkpoints_json_with_sidecars
v2_checkpoints_parquet_with_sidecars
v2_checkpoints_json_without_sidecars
v2_checkpoints_parquet_without_sidecars
v2_classic_checkpoint_json
v2_classic_checkpoint_parquet
v2_checkpoints_parquet_with_last_checkpoint
v2_checkpoints_json_with_last_checkpoint