Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade kafka-delta-ingest to delta-rs 0.22.3 #206

Closed
wants to merge 1 commit into from

Conversation

rtyler
Copy link
Member

@rtyler rtyler commented Dec 12, 2024

No description provided.

@mightyshazam
Copy link
Collaborator

It probably isn't a big deal, but we should note the newest delta-rs, due to delta-kernel-rs won't build without openssl because the kernel has a native-tls dependency due not using reqwest features.

@rtyler
Copy link
Member Author

rtyler commented Dec 12, 2024

@mightyshazam somebody mentioned that in Slack this morning! Do you have a reproduction case or issue filed I could fix? 😄

@mightyshazam
Copy link
Collaborator

mightyshazam commented Dec 12, 2024

It caught me in this delta-dotnet build. I didn't open an issue because I was going to assess the effort to fix it, but I will not get in your way. 💯
The default-engine includes reqwest when the feature is enabled. Since we don't have default-features = false or features to control native vs rust-tls, we get the default behavior, which includes native-tls

@mightyshazam
Copy link
Collaborator

There is a pending PR for it. delta-io/delta-kernel-rs#572

@rtyler
Copy link
Member Author

rtyler commented Jan 2, 2025

I'm closing this and will create a new pull request with the 0.23 release of delta-rs

@rtyler rtyler closed this Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants