refactor(lsp): make TS host use CLI snapshot (#28062)

This commit changes the TS host implementation
in the LSP to use the same snapshot as the runtime worker
and web worker use.

This is due to upcoming V8 upgrade that might require
that all isolates in the same process use the exact same
snapshot.

cli/factory.rs

@@ -1194,7 +1194,7 @@ impl CliFactory {
       serve_port: cli_options.serve_port(),
       serve_host: cli_options.serve_host(),
       otel_config: self.cli_options()?.otel_config(),
-      startup_snapshot: crate::js::deno_isolate_init(),
+      startup_snapshot: deno_snapshots::CLI_SNAPSHOT,
     })
   }
 

cli/lsp/tsc.rs

@@ -4912,17 +4912,17 @@ fn run_tsc_thread(
   maybe_inspector_server: Option<Arc<InspectorServer>>,
 ) {
   let has_inspector_server = maybe_inspector_server.is_some();
-  // Create and setup a JsRuntime based on a snapshot. It is expected that the
-  // supplied snapshot is an isolate that contains the TypeScript language
-  // server.
+  let mut extensions =
+    deno_runtime::snapshot_info::get_extensions_in_snapshot();
+  extensions.push(deno_tsc::init_ops_and_esm(
+    performance,
+    specifier_map,
+    request_rx,
+  ));
   let mut tsc_runtime = JsRuntime::new(RuntimeOptions {
-    extensions: vec![deno_tsc::init_ops_and_esm(
-      performance,
-      specifier_map,
-      request_rx,
-    )],
+    extensions,
     create_params: create_isolate_create_params(),
-    startup_snapshot: None,
+    startup_snapshot: deno_snapshots::CLI_SNAPSHOT,
     inspector: has_inspector_server,
     ..Default::default()
   });

cli/main.rs

@@ -9,7 +9,6 @@ mod file_fetcher;
 mod graph_container;
 mod graph_util;
 mod http_util;
-mod js;
 mod jsr;
 mod lsp;
 mod module_loader;

cli/tsc/mod.rs

@@ -1410,13 +1410,17 @@ pub fn exec(request: Request) -> Result<Response, ExecError> {
   });
   let exec_source = format!("globalThis.exec({request_value})");
 
+  let mut extensions =
+    deno_runtime::snapshot_info::get_extensions_in_snapshot();
+  extensions.push(deno_cli_tsc::init_ops_and_esm(
+    request,
+    root_map,
+    remapped_specifiers,
+  ));
   let mut runtime = JsRuntime::new(RuntimeOptions {
-    extensions: vec![deno_cli_tsc::init_ops_and_esm(
-      request,
-      root_map,
-      remapped_specifiers,
-    )],
+    extensions,
     create_params: create_isolate_create_params(),
+    startup_snapshot: deno_snapshots::CLI_SNAPSHOT,
     ..Default::default()
   });
 
@@ -1562,47 +1566,6 @@ mod tests {
     exec(request)
   }
 
-  // TODO(bartlomieju): this test is segfaulting in V8, saying that there are too
-  // few external references registered. It seems to be a bug in our snapshotting
-  // logic. Because when we create TSC snapshot we register a few ops that
-  // are called during snapshotting time, V8 expects at least as many references
-  // when it starts up. The thing is that these ops are one-off - ie. they will never
-  // be used again after the snapshot is taken. We should figure out a mechanism
-  // to allow removing some of the ops before taking a snapshot.
-  #[ignore]
-  #[tokio::test]
-  async fn test_compiler_snapshot() {
-    let mut js_runtime = JsRuntime::new(RuntimeOptions {
-      startup_snapshot: None,
-      extensions: vec![super::deno_cli_tsc::init_ops_and_esm(
-        Request {
-          check_mode: TypeCheckMode::All,
-          config: Arc::new(TsConfig(json!({}))),
-          debug: false,
-          graph: Arc::new(ModuleGraph::new(GraphKind::TypesOnly)),
-          hash_data: 0,
-          maybe_npm: None,
-          maybe_tsbuildinfo: None,
-          root_names: vec![],
-        },
-        HashMap::new(),
-        HashMap::new(),
-      )],
-      ..Default::default()
-    });
-    js_runtime
-      .execute_script(
-        "<anon>",
-        r#"
-      if (!(globalThis.exec)) {
-          throw Error("bad");
-        }
-        console.log(`ts version: ${ts.version}`);
-      "#,
-      )
-      .unwrap();
-  }
-
   #[tokio::test]
   async fn test_create_hash() {
     let mut state = setup(None, Some(123), None).await;

cli/worker.rs

@@ -486,7 +486,7 @@ mod tests {
       RuntimePermissionDescriptorParser::new(crate::sys::CliSys::default()),
     );
     let options = WorkerOptions {
-      startup_snapshot: crate::js::deno_isolate_init(),
+      startup_snapshot: deno_snapshots::CLI_SNAPSHOT,
       ..Default::default()
     };
 

runtime/lib.rs

@@ -38,6 +38,7 @@ pub mod ops;
 pub mod permissions;
 #[cfg(feature = "snapshot")]
 pub mod snapshot;
+pub mod snapshot_info;
 pub mod tokio_util;
 #[cfg(feature = "transpile")]
 pub mod transpile;