fix: resolve shebang parse error in deno doc --test #26079
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magurotuna
requested changes
Oct 28, 2024
There was a problem hiding this comment.
Looks good!
One request though: could you add a test case for a doc test written in markdown? Something like:
# my-awesome-readme
This is a markdown file.
```ts
#!/usr/bin/env -S deno run --allow-read
import { assertEquals } from "@std/assert/equals";
assertEquals(1 + 2, 3);
```
|
@MujahedSafaa could you please add a test as pointed above so we can land this PR? |
dsherret
reviewed
Apr 15, 2025
|
@magurotuna I updated this pr with a test and fix. PTAL |
bartlomieju
pushed a commit
that referenced
this pull request
Apr 18, 2025
The bug has been fixed by updating the regex to ensure that the shebang characters (#!) are no longer excluded. This allows the shebang to be retained and parsed correctly. --------- Co-authored-by: David Sherret <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue reported in #26018.
Issue:
Running deno doc --test on a file that contains a shebang results in a parse error.
Solution:
The bug has been fixed by updating the regex to ensure that the shebang characters (#!) are no longer excluded. This allows the shebang to be retained and parsed correctly.
@bartlomieju
@dsherret