perf(lsp): add built-in tracing support for the LSP #27843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanwhit
force-pushed
the
lsp-tracing-redux
branch
from
62347e3 to
b83c056
Compare
bartlomieju
commented
Jan 31, 2025
| } | ||
| for (const oldEntry of LANGUAGE_SERVICE_ENTRIES.byScope.values()) { | ||
| oldEntry.ls.dispose(); | ||
| const span = ops.op_make_span(`serverRequest(${method})`, true); |
There was a problem hiding this comment.
This diff is huge - maybe rename this function to serverRequestInner and then add serverRequest that wraps it in the span and try/finally?
bartlomieju
commented
Jan 31, 2025
Comment on lines
+737
to
+745
| "getScriptVersion", | ||
| "fileExists", | ||
| "getScriptSnapshot", | ||
| "getCompilationSettings", | ||
| "getCurrentDirectory", | ||
| "useCaseSensitiveFileNames", | ||
| "getModuleSpecifierCache", | ||
| "getGlobalTypingsCacheLocation", | ||
| "getSourceFile", |
There was a problem hiding this comment.
What's the reason for excluding these? Too noisy?
bartlomieju
commented
Jan 31, 2025
There was a problem hiding this comment.
I think we should upstream these to our TS fork
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.