Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ext/node): support read-only database in node:sqlite #27930

Merged
merged 1 commit into from
Feb 3, 2025
Merged

fix(ext/node): support read-only database in node:sqlite #27930

merged 1 commit into from
Feb 3, 2025
+55 −14

Conversation

littledivy
Copy link
Member

Implements the readOnly option for DatabaseSync.

Permissions:
--allow-read=test.db --allow-write=test.db => all works
--allow-read=test.db => only readOnly dbs work, cannot create new db

marvinhagemeister
marvinhagemeister approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@littledivy littledivy merged commit b5c3f4f into denoland:main Feb 3, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@littledivy @marvinhagemeister