-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(ext/canvas): remove static link lcms2
#28002
Open
Hajime-san
wants to merge
12
commits into
denoland:main
Choose a base branch
from
Hajime-san:reduce-build-size
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+33
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcms2
lcms2
[WIP]
01b4348
to
c192e14
Compare
release build failure log on ...
tmpfs 5.0G 4.0K 5.0G 1% /run/user/1002
Compiling lcms2-sys v4.0.5
Compiling test_napi v0.1.0 (/home/runner/work/deno/deno/tests/napi)
Compiling lcms2 v6.1.0
Compiling deno_canvas v0.58.0 (/home/runner/work/deno/deno/ext/canvas)
Compiling deno_runtime v0.197.0 (/home/runner/work/deno/deno/runtime)
Compiling deno_lib v0.5.0 (/home/runner/work/deno/deno/cli/lib)
Compiling deno_snapshots v0.4.0 (/home/runner/work/deno/deno/cli/snapshot)
Compiling deno v2.1.9 (/home/runner/work/deno/deno/cli)
Compiling denort v2.1.9 (/home/runner/work/deno/deno/cli/rt)
error: linking with `clang-19` failed: exit status: 1
|
= note: LC_ALL="C" PATH="/home/runner/.rustup/toolchains/1.82.0-aarch64-unknown-linux-gnu/lib/rustlib/aarch64-unknown-linux-gnu/bin:/home/runner/.rustup/toolchains/1.82.0-aarch64-unknown-linux-gnu/lib/rustlib/aarch64-unknown-linux-gnu/bin:/home/runner/.rustup/toolchains/1.82.0-aarch64-unknown-linux-gnu/lib/rustlib/aarch64-unknown-linux-gnu/bin:/opt/hostedtoolcache/node/18.20.5/arm64/bin:/home/runner/.deno/bin:/opt/hostedtoolcache/deno/2.1.9/arm64:/snap/bin:/home/runner/.local/bin:/opt/pipx_bin:/home/runner/.cargo/bin:/home/runner/.config/composer/vendor/bin:/home/runner/.dotnet/tools:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin" VSLANG="1033" "clang-19" "/tmp/rustcC03qfo/symbols.o" "/home/runner/work/deno/deno/target/release/deps/deno_canvas-8cf24f032826e2ed.deno_canvas.5b5fbbb0ac03340b-cgu.0.rcgu.o" "-Wl,--as-needed" "-Wl,-Bstatic" "/tmp/rustcC03qfo/libv8-897e3adb28b0cac4.rlib" "/tmp/rustcC03qfo/liblibz_sys-6b3578b89b[46](https://github.com/denoland/deno/actions/runs/13191927681/job/36826319336?pr=28002#step:35:47)fc52.rlib" "/home/runner/.rustup/toolchains/1.82.0-aarch64-unknown-linux-gnu/lib/rustlib/aarch64-unknown-linux-gnu/lib/libcompiler_builtins-6d60f560e3825be6.rlib" "-Wl,-Bdynamic" "-llcms2" "-lgcc_s" "-lutil" "-lrt" "-lpthread" "-lm" "-ldl" "-lc" "-Wl,--eh-frame-hdr" "-Wl,-z,noexecstack" "-Wl,-plugin-opt=O2,-plugin-opt=mcpu=generic" "-L" "/home/runner/work/deno/deno/target/release/gn_out/obj" "-L" "/home/runner/work/deno/deno/target/release/build/libz-sys-8c5a1613[49](https://github.com/denoland/deno/actions/runs/13191927681/job/36826319336?pr=28002#step:35:50)c0a703/out/lib" "-L" "/home/runner/work/deno/deno/target/release/build/libz-sys-8c5a161349c0a703/out/lib64" "-L" "/usr/lib/aarch64-linux-gnu" "-L" "/home/runner/.rustup/toolchains/1.82.0-aarch64-unknown-linux-gnu/lib/rustlib/aarch64-unknown-linux-gnu/lib" "-o" "/home/runner/work/deno/deno/target/release/deps/deno_canvas-8cf24f032826e2ed" "-Wl,--gc-sections" "-pie" "-Wl,-z,relro,-z,now" "-Wl,--strip-debug" "-nodefaultlibs" "-fuse-ld=lld-19" "-ldl" "-Wl,--allow-shlib-undefined" "-Wl,--thinlto-cache-dir=/home/runner/target/release/lto-cache" "-Wl,--thinlto-cache-policy,cache_size_bytes=700m" "-L/sysroot/lib/aarch64-linux-gnu" "-L/sysroot/usr/lib/aarch64-linux-gnu" "--sysroot=/sysroot"
= note: ld.lld-19: error: undefined symbol: __libc_csu_init
>>> referenced by /sysroot/usr/lib/aarch64-linux-gnu/Scrt1.o:(.text+0x20)
>>> referenced by /sysroot/usr/lib/aarch64-linux-gnu/Scrt1.o:(.text+0x24)
ld.lld-19: error: undefined symbol: __libc_csu_fini
>>> referenced by /sysroot/usr/lib/aarch64-linux-gnu/Scrt1.o:(.text+0x28)
>>> referenced by /sysroot/usr/lib/aarch64-linux-gnu/Scrt1.o:(.text+0x2C)
clang-19: error: linker command failed with exit code 1 (use -v to see invocation)
error: could not compile `deno_canvas` (lib test) due to 1 previous error
warning: build failed, waiting for other jobs to finish...
error: linking with `clang-19` failed: exit status: 1
... |
6ea5a7a
to
e5fee73
Compare
There is a same error when adding Set up incremental LTO and sysroot build before build step on GitHub's log
Run cargo build --release --verbose --target aarch64-unknown-linux-gnu
Fresh unicode-ident v1.0.16
Fresh shlex v1.3.0
Fresh dunce v1.0.5
Fresh pkg-config v0.3.31
Fresh jobserver v0.1.32
Fresh proc-macro2 v1.0.93
Dirty libc v0.2.169: the rustflags changed
Compiling libc v0.2.169
Dirty foreign-types-shared v0.3.1: the rustflags changed
Compiling foreign-types-shared v0.3.1
Fresh quote v1.0.38
Fresh cc v1.2.12
Fresh syn v2.0.98
Fresh foreign-types-macros v0.2.3
Dirty lcms2-sys v4.0.5: the rustflags changed
Compiling lcms2-sys v4.0.5
Dirty bytemuck v1.21.0: the rustflags changed
Compiling bytemuck v1.21.0
Running `/home/runner/work/test_build_lcms2-aarch64-unknown-linux-gnu/test_build_lcms2-aarch64-unknown-linux-gnu/target/release/build/libc-c353ddfc09b7f1bd/build-script-build`
Running `/home/runner/.rustup/toolchains/stable-aarch64-unknown-linux-gnu/bin/rustc --crate-name foreign_types_shared --edition=2018 /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/foreign-types-shared-0.3.1/src/lib.rs --error-format=json --json=diagnostic-rendered-ansi,artifacts,future-incompat --crate-type lib --emit=dep-info,metadata,link -C opt-level=3 -C embed-bitcode=no --check-cfg 'cfg(docsrs)' --check-cfg 'cfg(feature, values())' -C metadata=0dc6694a7883c940 -C extra-filename=-0dc6694a7883c940 --out-dir /home/runner/work/test_build_lcms2-aarch64-unknown-linux-gnu/test_build_lcms2-aarch64-unknown-linux-gnu/target/aarch64-unknown-linux-gnu/release/deps --target aarch64-unknown-linux-gnu -C strip=debuginfo -L dependency=/home/runner/work/test_build_lcms2-aarch64-unknown-linux-gnu/test_build_lcms2-aarch64-unknown-linux-gnu/target/aarch64-unknown-linux-gnu/release/deps -L dependency=/home/runner/work/test_build_lcms2-aarch64-unknown-linux-gnu/test_build_lcms2-aarch64-unknown-linux-gnu/target/release/deps --cap-lints allow -C linker-plugin-lto=true -C linker=clang-19 -C link-arg=-fuse-ld=lld-19 -C link-arg=-ldl -C link-arg=-Wl,--allow-shlib-undefined -C link-arg=-Wl,--thinlto-cache-dir=/home/runner/target/release/lto-cache -C link-arg=-Wl,--thinlto-cache-policy,cache_size_bytes=700m --cfg tokio_unstable -C link-arg=-L/sysroot/lib/aarch64-linux-gnu -C link-arg=-L/sysroot/usr/lib/aarch64-linux-gnu -C link-arg=--sysroot=/sysroot`
Running `/home/runner/.rustup/toolchains/stable-aarch64-unknown-linux-gnu/bin/rustc --crate-name bytemuck --edition=2018 /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/bytemuck-1.21.0/src/lib.rs --error-format=json --json=diagnostic-rendered-ansi,artifacts,future-incompat --crate-type lib --emit=dep-info,metadata,link -C opt-level=3 -C embed-bitcode=no --deny=unexpected_cfgs --check-cfg 'cfg(target_arch, values("spirv"))' --check-cfg 'cfg(docsrs)' --check-cfg 'cfg(feature, values("aarch64_simd", "align_offset", "alloc_uninit", "avx512_simd", "bytemuck_derive", "const_zeroed", "derive", "extern_crate_alloc", "extern_crate_std", "latest_stable_rust", "min_const_generics", "must_cast", "must_cast_extra", "nightly_docs", "nightly_float", "nightly_portable_simd", "nightly_stdsimd", "track_caller", "transparentwrapper_extra", "unsound_ptr_pod_impl", "wasm_simd", "zeroable_atomics", "zeroable_maybe_uninit"))' -C metadata=b9cfbbe5de9e5604 -C extra-filename=-b9cfbbe5de9e5604 --out-dir /home/runner/work/test_build_lcms2-aarch64-unknown-linux-gnu/test_build_lcms2-aarch64-unknown-linux-gnu/target/aarch64-unknown-linux-gnu/release/deps --target aarch64-unknown-linux-gnu -C strip=debuginfo -L dependency=/home/runner/work/test_build_lcms2-aarch64-unknown-linux-gnu/test_build_lcms2-aarch64-unknown-linux-gnu/target/aarch64-unknown-linux-gnu/release/deps -L dependency=/home/runner/work/test_build_lcms2-aarch64-unknown-linux-gnu/test_build_lcms2-aarch64-unknown-linux-gnu/target/release/deps --cap-lints allow -C linker-plugin-lto=true -C linker=clang-19 -C link-arg=-fuse-ld=lld-19 -C link-arg=-ldl -C link-arg=-Wl,--allow-shlib-undefined -C link-arg=-Wl,--thinlto-cache-dir=/home/runner/target/release/lto-cache -C link-arg=-Wl,--thinlto-cache-policy,cache_size_bytes=700m --cfg tokio_unstable -C link-arg=-L/sysroot/lib/aarch64-linux-gnu -C link-arg=-L/sysroot/usr/lib/aarch64-linux-gnu -C link-arg=--sysroot=/sysroot`
Running `/home/runner/work/test_build_lcms2-aarch64-unknown-linux-gnu/test_build_lcms2-aarch64-unknown-linux-gnu/target/release/build/lcms2-sys-db30561edb7e6e72/build-script-build`
Running `/home/runner/.rustup/toolchains/stable-aarch64-unknown-linux-gnu/bin/rustc --crate-name libc --edition=2021 /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/libc-0.2.169/src/lib.rs --error-format=json --json=diagnostic-rendered-ansi,artifacts,future-incompat --crate-type lib --emit=dep-info,metadata,link -C opt-level=3 -C embed-bitcode=no --cfg 'feature="default"' --cfg 'feature="std"' --check-cfg 'cfg(docsrs)' --check-cfg 'cfg(feature, values("align", "const-extern-fn", "default", "extra_traits", "rustc-dep-of-std", "rustc-std-workspace-core", "std", "use_std"))' -C metadata=168ba380a4a2c025 -C extra-filename=-168ba380a4a2c025 --out-dir /home/runner/work/test_build_lcms2-aarch64-unknown-linux-gnu/test_build_lcms2-aarch64-unknown-linux-gnu/target/aarch64-unknown-linux-gnu/release/deps --target aarch64-unknown-linux-gnu -C strip=debuginfo -L dependency=/home/runner/work/test_build_lcms2-aarch64-unknown-linux-gnu/test_build_lcms2-aarch64-unknown-linux-gnu/target/aarch64-unknown-linux-gnu/release/deps -L dependency=/home/runner/work/test_build_lcms2-aarch64-unknown-linux-gnu/test_build_lcms2-aarch64-unknown-linux-gnu/target/release/deps --cap-lints allow -C linker-plugin-lto=true -C linker=clang-19 -C link-arg=-fuse-ld=lld-19 -C link-arg=-ldl -C link-arg=-Wl,--allow-shlib-undefined -C link-arg=-Wl,--thinlto-cache-dir=/home/runner/target/release/lto-cache -C link-arg=-Wl,--thinlto-cache-policy,cache_size_bytes=700m --cfg tokio_unstable -C link-arg=-L/sysroot/lib/aarch64-linux-gnu -C link-arg=-L/sysroot/usr/lib/aarch64-linux-gnu -C link-arg=--sysroot=/sysroot --cfg freebsd11 --cfg libc_const_extern_fn --check-cfg 'cfg(emscripten_new_stat_abi)' --check-cfg 'cfg(espidf_time32)' --check-cfg 'cfg(freebsd10)' --check-cfg 'cfg(freebsd11)' --check-cfg 'cfg(freebsd12)' --check-cfg 'cfg(freebsd13)' --check-cfg 'cfg(freebsd14)' --check-cfg 'cfg(freebsd15)' --check-cfg 'cfg(libc_const_extern_fn)' --check-cfg 'cfg(libc_deny_warnings)' --check-cfg 'cfg(libc_thread_local)' --check-cfg 'cfg(libc_ctest)' --check-cfg 'cfg(target_os,values("switch","aix","ohos","hurd","rtems","visionos","nuttx"))' --check-cfg 'cfg(target_env,values("illumos","wasi","aix","ohos"))' --check-cfg 'cfg(target_arch,values("loongarch64","mips32r6","mips64r6","csky"))'`
Dirty foreign-types v0.5.0: the rustflags changed
Compiling foreign-types v0.5.0
Running `/home/runner/.rustup/toolchains/stable-aarch64-unknown-linux-gnu/bin/rustc --crate-name foreign_types --edition=2018 /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/foreign-types-0.5.0/src/lib.rs --error-format=json --json=diagnostic-rendered-ansi,artifacts,future-incompat --crate-type lib --emit=dep-info,metadata,link -C opt-level=3 -C embed-bitcode=no --cfg 'feature="default"' --cfg 'feature="std"' --check-cfg 'cfg(docsrs)' --check-cfg 'cfg(feature, values("default", "std"))' -C metadata=c86c54e9566f7d58 -C extra-filename=-c86c54e9566f7d58 --out-dir /home/runner/work/test_build_lcms2-aarch64-unknown-linux-gnu/test_build_lcms2-aarch64-unknown-linux-gnu/target/aarch64-unknown-linux-gnu/release/deps --target aarch64-unknown-linux-gnu -C strip=debuginfo -L dependency=/home/runner/work/test_build_lcms2-aarch64-unknown-linux-gnu/test_build_lcms2-aarch64-unknown-linux-gnu/target/aarch64-unknown-linux-gnu/release/deps -L dependency=/home/runner/work/test_build_lcms2-aarch64-unknown-linux-gnu/test_build_lcms2-aarch64-unknown-linux-gnu/target/release/deps --extern foreign_types_macros=/home/runner/work/test_build_lcms2-aarch64-unknown-linux-gnu/test_build_lcms2-aarch64-unknown-linux-gnu/target/release/deps/libforeign_types_macros-a762f91[28](https://github.com/Hajime-san/test_build_lcms2-aarch64-unknown-linux-gnu/actions/runs/13194972772/job/36834492116#step:5:29)9ded7e5.so --extern foreign_types_shared=/home/runner/work/test_build_lcms2-aarch64-unknown-linux-gnu/test_build_lcms2-aarch64-unknown-linux-gnu/target/aarch64-unknown-linux-gnu/release/deps/libforeign_types_shared-0dc6694a7883c940.rmeta --cap-lints allow -C linker-plugin-lto=true -C linker=clang-19 -C link-arg=-fuse-ld=lld-19 -C link-arg=-ldl -C link-arg=-Wl,--allow-shlib-undefined -C link-arg=-Wl,--thinlto-cache-dir=/home/runner/target/release/lto-cache -C link-arg=-Wl,--thinlto-cache-policy,cache_size_bytes=700m --cfg tokio_unstable -C link-arg=-L/sysroot/lib/aarch64-linux-gnu -C link-arg=-L/sysroot/usr/lib/aarch64-linux-gnu -C link-arg=--sysroot=/sysroot`
Running `/home/runner/.rustup/toolchains/stable-aarch64-unknown-linux-gnu/bin/rustc --crate-name lcms2_sys --edition=2021 /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/lcms2-sys-4.0.5/src/lib.rs --error-format=json --json=diagnostic-rendered-ansi,artifacts,future-incompat --crate-type lib --emit=dep-info,metadata,link -C opt-level=3 -C embed-bitcode=no --cfg 'feature="default"' --cfg 'feature="dynamic"' --cfg 'feature="parallel"' --cfg 'feature="static-fallback"' --check-cfg 'cfg(docsrs)' --check-cfg 'cfg(feature, values("default", "dynamic", "lcms2-strict-cgats", "parallel", "static", "static-fallback"))' -C metadata=717d6ddc492dedc4 -C extra-filename=-717d6ddc492dedc4 --out-dir /home/runner/work/test_build_lcms2-aarch64-unknown-linux-gnu/test_build_lcms2-aarch64-unknown-linux-gnu/target/aarch64-unknown-linux-gnu/release/deps --target aarch64-unknown-linux-gnu -C strip=debuginfo -L dependency=/home/runner/work/test_build_lcms2-aarch64-unknown-linux-gnu/test_build_lcms2-aarch64-unknown-linux-gnu/target/aarch64-unknown-linux-gnu/release/deps -L dependency=/home/runner/work/test_build_lcms2-aarch64-unknown-linux-gnu/test_build_lcms2-aarch64-unknown-linux-gnu/target/release/deps --extern libc=/home/runner/work/test_build_lcms2-aarch64-unknown-linux-gnu/test_build_lcms2-aarch64-unknown-linux-gnu/target/aarch64-unknown-linux-gnu/release/deps/liblibc-168ba380a4a2c025.rmeta --cap-lints allow -C linker-plugin-lto=true -C linker=clang-19 -C link-arg=-fuse-ld=lld-19 -C link-arg=-ldl -C link-arg=-Wl,--allow-shlib-undefined -C link-arg=-Wl,--thinlto-cache-dir=/home/runner/target/release/lto-cache -C link-arg=-Wl,--thinlto-cache-policy,cache_size_bytes=700m --cfg tokio_unstable -C link-arg=-L/sysroot/lib/aarch64-linux-gnu -C link-arg=-L/sysroot/usr/lib/aarch64-linux-gnu -C link-arg=--sysroot=/sysroot -L native=/usr/lib/aarch64-linux-gnu -l lcms2`
Dirty lcms2 v6.1.0: the rustflags changed
Compiling lcms2 v6.1.0
Running `/home/runner/.rustup/toolchains/stable-aarch64-unknown-linux-gnu/bin/rustc --crate-name lcms2 --edition=2021 /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/lcms2-6.1.0/src/lib.rs --error-format=json --json=diagnostic-rendered-ansi,artifacts,future-incompat --crate-type lib --emit=dep-info,metadata,link -C opt-level=3 -C embed-bitcode=no --check-cfg 'cfg(docsrs)' --check-cfg 'cfg(feature, values("static"))' -C metadata=db4bddc12567763b -C extra-filename=-db4bddc12567763b --out-dir /home/runner/work/test_build_lcms2-aarch64-unknown-linux-gnu/test_build_lcms2-aarch64-unknown-linux-gnu/target/aarch64-unknown-linux-gnu/release/deps --target aarch64-unknown-linux-gnu -C strip=debuginfo -L dependency=/home/runner/work/test_build_lcms2-aarch64-unknown-linux-gnu/test_build_lcms2-aarch64-unknown-linux-gnu/target/aarch64-unknown-linux-gnu/release/deps -L dependency=/home/runner/work/test_build_lcms2-aarch64-unknown-linux-gnu/test_build_lcms2-aarch64-unknown-linux-gnu/target/release/deps --extern bytemuck=/home/runner/work/test_build_lcms2-aarch64-unknown-linux-gnu/test_build_lcms2-aarch64-unknown-linux-gnu/target/aarch64-unknown-linux-gnu/release/deps/libbytemuck-b9cfbbe5de9e5604.rmeta --extern foreign_types=/home/runner/work/test_build_lcms2-aarch64-unknown-linux-gnu/test_build_lcms2-aarch64-unknown-linux-gnu/target/aarch64-unknown-linux-gnu/release/deps/libforeign_types-c86c54e9566f7d58.rmeta --extern lcms2_sys=/home/runner/work/test_build_lcms2-aarch64-unknown-linux-gnu/test_build_lcms2-aarch64-unknown-linux-gnu/target/aarch64-unknown-linux-gnu/release/deps/liblcms2_sys-717d6ddc492dedc4.rmeta --cap-lints allow -C linker-plugin-lto=true -C linker=clang-19 -C link-arg=-fuse-ld=lld-19 -C link-arg=-ldl -C link-arg=-Wl,--allow-shlib-undefined -C link-arg=-Wl,--thinlto-cache-dir=/home/runner/target/release/lto-cache -C link-arg=-Wl,--thinlto-cache-policy,cache_size_bytes=700m --cfg tokio_unstable -C link-arg=-L/sysroot/lib/aarch64-linux-gnu -C link-arg=-L/sysroot/usr/lib/aarch64-linux-gnu -C link-arg=--sysroot=/sysroot -L native=/usr/lib/aarch64-linux-gnu`
Dirty app v0.1.0 (/home/runner/work/test_build_lcms2-aarch64-unknown-linux-gnu/test_build_lcms2-aarch64-unknown-linux-gnu): the rustflags changed
Compiling app v0.1.0 (/home/runner/work/test_build_lcms2-aarch64-unknown-linux-gnu/test_build_lcms2-aarch64-unknown-linux-gnu)
Running `/home/runner/.rustup/toolchains/stable-aarch64-unknown-linux-gnu/bin/rustc --crate-name app --edition=2021 src/main.rs --error-format=json --json=diagnostic-rendered-ansi,artifacts,future-incompat --crate-type bin --emit=dep-info,link -C opt-level=3 -C embed-bitcode=no --check-cfg 'cfg(docsrs)' --check-cfg 'cfg(feature, values())' -C metadata=7fa9f9f6126be3e1 -C extra-filename=-7fa9f9f6126be3e1 --out-dir /home/runner/work/test_build_lcms2-aarch64-unknown-linux-gnu/test_build_lcms2-aarch64-unknown-linux-gnu/target/aarch64-unknown-linux-gnu/release/deps --target aarch64-unknown-linux-gnu -C strip=debuginfo -L dependency=/home/runner/work/test_build_lcms2-aarch64-unknown-linux-gnu/test_build_lcms2-aarch64-unknown-linux-gnu/target/aarch64-unknown-linux-gnu/release/deps -L dependency=/home/runner/work/test_build_lcms2-aarch64-unknown-linux-gnu/test_build_lcms2-aarch64-unknown-linux-gnu/target/release/deps --extern lcms2=/home/runner/work/test_build_lcms2-aarch64-unknown-linux-gnu/test_build_lcms2-aarch64-unknown-linux-gnu/target/aarch64-unknown-linux-gnu/release/deps/liblcms2-db4bddc12567763b.rlib -C linker-plugin-lto=true -C linker=clang-19 -C link-arg=-fuse-ld=lld-19 -C link-arg=-ldl -C link-arg=-Wl,--allow-shlib-undefined -C link-arg=-Wl,--thinlto-cache-dir=/home/runner/target/release/lto-cache -C link-arg=-Wl,--thinlto-cache-policy,cache_size_bytes=700m --cfg tokio_unstable -C link-arg=-L/sysroot/lib/aarch64-linux-gnu -C link-arg=-L/sysroot/usr/lib/aarch64-linux-gnu -C link-arg=--sysroot=/sysroot -L native=/usr/lib/aarch64-linux-gnu`
error: linking with `clang-19` failed: exit status: 1
|
= note: LC_ALL="C" PATH="/home/runner/.rustup/toolchains/stable-aarch64-unknown-linux-gnu/lib/rustlib/aarch64-unknown-linux-gnu/bin:/snap/bin:/home/runner/.local/bin:/opt/pipx_bin:/home/runner/.cargo/bin:/home/runner/.config/composer/vendor/bin:/opt/google-cloud-sdk/bin:/home/runner/.dotnet/tools:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin" VSLANG="1033" "clang-19" "/tmp/rustcVG9nHa/symbols.o" "/home/runner/work/test_build_lcms2-aarch64-unknown-linux-gnu/test_build_lcms2-aarch64-unknown-linux-gnu/target/aarch64-unknown-linux-gnu/release/deps/app-7fa9f9f6126be3e1.app.aa2c6a87071b681e-cgu.0.rcgu.o" "/home/runner/work/test_build_lcms2-aarch64-unknown-linux-gnu/test_build_lcms2-aarch64-unknown-linux-gnu/target/aarch64-unknown-linux-gnu/release/deps/app-7fa9f9f6126be3e1.asclaki6tjufltn2d3csx0zec.rcgu.o" "-Wl,--as-needed" "-Wl,-Bstatic" "/home/runner/work/test_build_lcms2-aarch64-unknown-linux-gnu/test_build_lcms2-aarch64-unknown-linux-gnu/target/aarch64-unknown-linux-gnu/release/deps/liblcms2-db4bddc12567763b.rlib" "/home/runner/work/test_build_lcms2-aarch64-unknown-linux-gnu/test_build_lcms2-aarch64-unknown-linux-gnu/target/aarch64-unknown-linux-gnu/release/deps/libbytemuck-b9cfbbe5de9e5604.rlib" "/home/runner/work/test_build_lcms2-aarch64-unknown-linux-gnu/test_build_lcms2-aarch64-unknown-linux-gnu/target/aarch64-unknown-linux-gnu/release/deps/libforeign_types-c86c54e9566f7d58.rlib" "/home/runner/work/test_build_lcms2-aarch64-unknown-linux-gnu/test_build_lcms2-aarch64-unknown-linux-gnu/target/aarch64-unknown-linux-gnu/release/deps/libforeign_types_shared-0dc6694a7883c940.rlib" "/home/runner/work/test_build_lcms2-aarch64-unknown-linux-gnu/test_build_lcms2-aarch64-unknown-linux-gnu/target/aarch64-unknown-linux-gnu/release/deps/liblcms2_sys-717d6ddc492dedc4.rlib" "/home/runner/work/test_build_lcms2-aarch64-unknown-linux-gnu/test_build_lcms2-aarch64-unknown-linux-gnu/target/aarch64-unknown-linux-gnu/release/deps/liblibc-168ba380a4a2c025.rlib" "/home/runner/.rustup/toolchains/stable-aarch64-unknown-linux-gnu/lib/rustlib/aarch64-unknown-linux-gnu/lib/libstd-6031cf49ae85e068.rlib" "/home/runner/.rustup/toolchains/stable-aarch64-unknown-linux-gnu/lib/rustlib/aarch64-unknown-linux-gnu/lib/libpanic_unwind-1eae8079287bfd9e.rlib" "/home/runner/.rustup/toolchains/stable-aarch64-unknown-linux-gnu/lib/rustlib/aarch64-unknown-linux-gnu/lib/libobject-ed093fb97db090e3.rlib" "/home/runner/.rustup/toolchains/stable-aarch64-unknown-linux-gnu/lib/rustlib/aarch64-unknown-linux-gnu/lib/libmemchr-db4ea5ef12fae7ea.rlib" "/home/runner/.rustup/toolchains/stable-aarch64-unknown-linux-gnu/lib/rustlib/aarch64-unknown-linux-gnu/lib/libaddr2line-2580189219589eeb.rlib" "/home/runner/.rustup/toolchains/stable-aarch64-unknown-linux-gnu/lib/rustlib/aarch64-unknown-linux-gnu/lib/libgimli-886d3eab83[30](https://github.com/Hajime-san/test_build_lcms2-aarch64-unknown-linux-gnu/actions/runs/13194972772/job/36834492116#step:5:31)732f.rlib" "/home/runner/.rustup/toolchains/stable-aarch64-unknown-linux-gnu/lib/rustlib/aarch64-unknown-linux-gnu/lib/librustc_demangle-6c85e81b65ecde70.rlib" "/home/runner/.rustup/toolchains/stable-aarch64-unknown-linux-gnu/lib/rustlib/aarch64-unknown-linux-gnu/lib/libstd_detect-78900e4ba241b2a6.rlib" "/home/runner/.rustup/toolchains/stable-aarch64-unknown-linux-gnu/lib/rustlib/aarch64-unknown-linux-gnu/lib/libhashbrown-ddecc1d3d2463010.rlib" "/home/runner/.rustup/toolchains/stable-aarch64-unknown-linux-gnu/lib/rustlib/aarch64-unknown-linux-gnu/lib/librustc_std_workspace_alloc-24b06192d7ffac4c.rlib" "/home/runner/.rustup/toolchains/stable-aarch64-unknown-linux-gnu/lib/rustlib/aarch64-unknown-linux-gnu/lib/libminiz_oxide-bff165d1bc903c8b.rlib" "/home/runner/.rustup/toolchains/stable-aarch64-unknown-linux-gnu/lib/rustlib/aarch64-unknown-linux-gnu/lib/libadler-0e4bd6ddbacfe0fc.rlib" "/home/runner/.rustup/toolchains/stable-aarch64-unknown-linux-gnu/lib/rustlib/aarch64-unknown-linux-gnu/lib/libunwind-420fc5fc57ff7d9e.rlib" "/home/runner/.rustup/toolchains/stable-aarch64-unknown-linux-gnu/lib/rustlib/aarch64-unknown-linux-gnu/lib/libcfg_if-cdcef051b6015e38.rlib" "/home/runner/.rustup/toolchains/stable-aarch64-unknown-linux-gnu/lib/rustlib/aarch64-unknown-linux-gnu/lib/liblibc-7152dd0215e4c421.rlib" "/home/runner/.rustup/toolchains/stable-aarch64-unknown-linux-gnu/lib/rustlib/aarch64-unknown-linux-gnu/lib/liballoc-9d15fe2f5c03d[33](https://github.com/Hajime-san/test_build_lcms2-aarch64-unknown-linux-gnu/actions/runs/13194972772/job/36834492116#step:5:34)e.rlib" "/home/runner/.rustup/toolchains/stable-aarch64-unknown-linux-gnu/lib/rustlib/aarch64-unknown-linux-gnu/lib/librustc_std_workspace_core-3ecf1b05b3a94862.rlib" "/home/runner/.rustup/toolchains/stable-aarch64-unknown-linux-gnu/lib/rustlib/aarch64-unknown-linux-gnu/lib/libcore-f75b3043b9a7467a.rlib" "/home/runner/.rustup/toolchains/stable-aarch64-unknown-linux-gnu/lib/rustlib/aarch64-unknown-linux-gnu/lib/libcompiler_builtins-d3c20515d689c7cc.rlib" "-Wl,-Bdynamic" "-llcms2" "-lgcc_s" "-lutil" "-lrt" "-lpthread" "-lm" "-ldl" "-lc" "-Wl,--eh-frame-hdr" "-Wl,-z,noexecstack" "-Wl,-plugin-opt=O3,-plugin-opt=mcpu=generic" "-L" "/usr/lib/aarch64-linux-gnu" "-L" "/home/runner/.rustup/toolchains/stable-aarch64-unknown-linux-gnu/lib/rustlib/aarch64-unknown-linux-gnu/lib" "-o" "/home/runner/work/test_build_lcms2-aarch64-unknown-linux-gnu/test_build_lcms2-aarch64-unknown-linux-gnu/target/aarch64-unknown-linux-gnu/release/deps/app-7fa9f9f6126be3e1" "-Wl,--gc-sections" "-pie" "-Wl,-z,relro,-z,now" "-Wl,-O1" "-Wl,--strip-debug" "-nodefaultlibs" "-fuse-ld=lld-19" "-ldl" "-Wl,--allow-shlib-undefined" "-Wl,--thinlto-cache-dir=/home/runner/target/release/lto-cache" "-Wl,--thinlto-cache-policy,cache_size_bytes=700m" "-L/sysroot/lib/aarch64-linux-gnu" "-L/sysroot/usr/lib/aarch64-linux-gnu" "--sysroot=/sysroot"
= note: ld.lld-19: error: undefined symbol: __libc_csu_init
>>> referenced by /sysroot/usr/lib/aarch64-linux-gnu/Scrt1.o:(.text+0x20)
>>> referenced by /sysroot/usr/lib/aarch64-linux-gnu/Scrt1.o:(.text+0x24)
ld.lld-19: error: undefined symbol: __libc_csu_fini
>>> referenced by /sysroot/usr/lib/aarch64-linux-gnu/Scrt1.o:(.text+0x28)
>>> referenced by /sysroot/usr/lib/aarch64-linux-gnu/Scrt1.o:(.text+0x2C)
clang-19: error: linker command failed with exit code 1 (use -v to see invocation)
error: could not compile `app` (bin "app") due to 1 previous error
Caused by:
process didn't exit successfully: `/home/runner/.rustup/toolchains/stable-aarch64-unknown-linux-gnu/bin/rustc --crate-name app --edition=2021 src/main.rs --error-format=json --json=diagnostic-rendered-ansi,artifacts,future-incompat --crate-type bin --emit=dep-info,link -C opt-level=3 -C embed-bitcode=no --check-cfg 'cfg(docsrs)' --check-cfg 'cfg(feature, values())' -C metadata=7fa9f9f6126be3e1 -C extra-filename=-7fa9f9f6126be3e1 --out-dir /home/runner/work/test_build_lcms2-aarch64-unknown-linux-gnu/test_build_lcms2-aarch64-unknown-linux-gnu/target/aarch64-unknown-linux-gnu/release/deps --target aarch64-unknown-linux-gnu -C strip=debuginfo -L dependency=/home/runner/work/test_build_lcms2-aarch64-unknown-linux-gnu/test_build_lcms2-aarch64-unknown-linux-gnu/target/aarch64-unknown-linux-gnu/release/deps -L dependency=/home/runner/work/test_build_lcms2-aarch64-unknown-linux-gnu/test_build_lcms2-aarch64-unknown-linux-gnu/target/release/deps --extern lcms2=/home/runner/work/test_build_lcms2-aarch64-unknown-linux-gnu/test_build_lcms2-aarch64-unknown-linux-gnu/target/aarch64-unknown-linux-gnu/release/deps/liblcms2-db4bddc12567763b.rlib -C linker-plugin-lto=true -C linker=clang-19 -C link-arg=-fuse-ld=lld-19 -C link-arg=-ldl -C link-arg=-Wl,--allow-shlib-undefined -C link-arg=-Wl,--thinlto-cache-dir=/home/runner/target/release/lto-cache -C link-arg=-Wl,--thinlto-cache-policy,cache_size_bytes=700m --cfg tokio_unstable -C link-arg=-L/sysroot/lib/aarch64-linux-gnu -C link-arg=-L/sysroot/usr/lib/aarch64-linux-gnu -C link-arg=--sysroot=/sysroot -L native=/usr/lib/aarch64-linux-gnu` (exit status: 1)
Error: Process completed with exit code 101. |
e5fee73
to
63c1c31
Compare
lcms2
[WIP]lcms2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #25517 (comment)
Summary
It reduces the build size by linking
lcms2
crate dynamically instead of statically.Internally,
lcms2
depends onlcms2-sys
crate, an lcms2 FFI, and who can choose whether to link statically or dynamically via the cargo feature.If I switched to dynamic linking,
pkg-config
, whichlcm2-sys
depends on, failed to link due to an incomplete path when built on CIaaarch64-linux-gnu
.Therefore, I wrote an additional script to set the path for
pkg-config
.This link failure seems to be reproduced only when building
aaarch64-linux-gnu
with sysroot.For details, see my reproduction repository.
At first glance, it may seem like a bug, but
pkg-config
itself is not a tool that supports cross-compilation, so I think it is reasonable for the software (Deno) that performs cross-compilation to bear the responsibility for resolving it.performance
my environment
% uname -a Darwin user.local 23.5.0 Darwin Kernel Version 23.5.0: Wed May 1 20:16:51 PDT 2024; root:xnu-10063.121.3~5/RELEASE_ARM64_T8103 arm64
build size
It's 220kb smaller.
main on df02af2
this pr on 333591d
API bench
sample code below
It seems to be almost same.
main on df02af2
this pr on 333591d