Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lint): Deno.lint.runPlugin throws in deno run #28063

Merged
merged 2 commits into from
Feb 12, 2025
Merged

fix(lint): Deno.lint.runPlugin throws in deno run #28063

merged 2 commits into from
Feb 12, 2025

Conversation

bartlomieju
Copy link
Member

This commit changes Deno.lint.runPlugin to throw
in non-deno test subcommand, instead of returning
undefined.

marvinhagemeister
marvinhagemeister approved these changes Feb 11, 2025
View reviewed changes
Copy link
Contributor

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju enabled auto-merge (squash) February 11, 2025 17:32
@bartlomieju bartlomieju merged commit d29f9f9 into denoland:main Feb 12, 2025
17 checks passed
@bartlomieju bartlomieju deleted the lint_plugin branch February 12, 2025 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bartlomieju @marvinhagemeister