Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Upgrade V8 to 13.4 #28080

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: Upgrade V8 to 13.4 #28080

wants to merge 2 commits into from
+399 −1,831

Conversation

devsnek
Copy link
Member

@devsnek devsnek commented Feb 12, 2025 •
edited
Loading

  • upgrade v8 to 13.4
  • turbocall conversion for arraybuffers is now much more complex, so use cranelift
  • misc updates for deprecated fns

@bartlomieju bartlomieju mentioned this pull request Feb 12, 2025
Closed
bartlomieju
bartlomieju reviewed Feb 12, 2025
View reviewed changes
ext/ffi/turbocall.rs Outdated
@@ -1559,19 +1609,52 @@ mod tests {
// See https://godbolt.org/z/hqv63M3Ko
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These links are probably out of date now?

@devsnek devsnek force-pushed the x/upgrade-v8-134 branch 4 times, most recently from 7108fa4 to 368b70b Compare February 13, 2025 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devsnek @bartlomieju