Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lint): don't mark plugin diagnostic as fixable, if it's not #28147

Merged
merged 3 commits into from
Feb 17, 2025

Conversation

bartlomieju
Copy link
Member

@bartlomieju bartlomieju commented Feb 17, 2025

A vector with fixes was always created, even if there were no
applicable fixes.

@bartlomieju bartlomieju enabled auto-merge (squash) February 17, 2025 13:46
@dsherret dsherret disabled auto-merge February 17, 2025 13:57
@bartlomieju bartlomieju requested a review from dsherret February 17, 2025 14:10
@bartlomieju bartlomieju enabled auto-merge (squash) February 17, 2025 14:11
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju merged commit 1f169f4 into denoland:main Feb 17, 2025
17 checks passed
@bartlomieju bartlomieju deleted the lint_plugins_fixable branch February 17, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants