Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix border colour on dark mode (and also looks fine in light mode) #1495

Merged
merged 1 commit into from
Feb 26, 2025
Merged

Fix border colour on dark mode (and also looks fine in light mode) #1495

merged 1 commit into from
Feb 26, 2025

Conversation

thisisjofrank
Copy link
Collaborator

@thisisjofrank thisisjofrank commented Feb 26, 2025 •
edited
Loading

Closes #1492

Before:
image

After:
image

@thisisjofrank thisisjofrank changed the title define colour of border Fix border colour on dark mode (and also looks fine in light mode) Feb 26, 2025
@thisisjofrank thisisjofrank marked this pull request as ready for review February 26, 2025 10:48
@thisisjofrank thisisjofrank mentioned this pull request Feb 26, 2025
Open
philhawksworth
philhawksworth approved these changes Feb 26, 2025
View reviewed changes
Copy link
Member

@philhawksworth philhawksworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this one.
LGTM!

@thisisjofrank thisisjofrank merged commit c0a4ede into main Feb 26, 2025
4 checks passed
@thisisjofrank thisisjofrank deleted the codeblock-border branch February 26, 2025 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philhawksworth philhawksworth philhawksworth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: dark mode weird border around code snippets
2 participants
@thisisjofrank @philhawksworth