-
Notifications
You must be signed in to change notification settings - Fork 643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(ini): simplify stringify()
#6514
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6514 +/- ##
==========================================
- Coverage 95.29% 95.09% -0.21%
==========================================
Files 576 576
Lines 43315 43329 +14
Branches 6477 6460 -17
==========================================
- Hits 41279 41204 -75
- Misses 1995 2084 +89
Partials 41 41 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Can you reduce unrelated changes (in @std/encoding)? |
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
This PR moves all stringify functionality from
IniMap
into thestringify()
function.There is a load of unnecessary overhead generated the way
stringify()
works inIniMap
.Together with #6512
IniMap
will become obsolete and can be removed afterwards.