Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ini): simplify stringify() #6514

Merged
merged 10 commits into from
Apr 1, 2025

Conversation

timreichen
Copy link
Contributor

This PR moves all stringify functionality from IniMap into the stringify() function.
There is a load of unnecessary overhead generated the way stringify() works in IniMap.

Together with #6512 IniMap will become obsolete and can be removed afterwards.

@timreichen timreichen requested a review from kt3k as a code owner March 25, 2025 09:41
@github-actions github-actions bot added the ini label Mar 25, 2025
Copy link

codecov bot commented Mar 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.09%. Comparing base (61f9fd3) to head (6dc1cd0).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6514      +/-   ##
==========================================
- Coverage   95.29%   95.09%   -0.21%     
==========================================
  Files         576      576              
  Lines       43315    43329      +14     
  Branches     6477     6460      -17     
==========================================
- Hits        41279    41204      -75     
- Misses       1995     2084      +89     
  Partials       41       41              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kt3k
Copy link
Member

kt3k commented Mar 27, 2025

Can you reduce unrelated changes (in @std/encoding)?

@github-actions github-actions bot removed the encoding label Mar 27, 2025
@timreichen
Copy link
Contributor Author

Can you reduce unrelated changes (in @std/encoding)?

Done

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@kt3k kt3k merged commit ad62571 into denoland:main Apr 1, 2025
18 checks passed
@timreichen timreichen deleted the ini-simplify-stringify branch April 1, 2025 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants