test(datetime): test each part type in dateTimeFormatter.format #6516
+243
−58
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, larger tests meant these appeared to be covered, but there was no testing of the deep specifications for each part type. Covering the cases revealed a bug with
fractionalSecond
, and the fix is included in this PR.I also made
formatToParts
require exactly 2 digits when parsingyy
and exactly 4 digits when parsingyyyy
instead of 1-2 or 1-4 respectively. The spec requiresyy
to represent exactly 2 digits, butyyyy
technically represents 4+ digits. In neither case are fewer digits allowed. I think it's unlikely anyone will be trying to parse years with 5+ digits, and parsingyyyyMMdd
would require a more sophisticated approach if we allowed 5+, so I think only allowing 4 is best.