ロビー画面を作る #95
Merged
ロビー画面を作る #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
アセットの導入は別PRにわけた方がよかったですね… |
chromee
commented
Oct 18, 2017
|
|
||
| player.name = lobby.playerName; | ||
| player.playerId = lobby.playerId; | ||
| player.teamId = lobby.teamId; |
| StartCoroutine(SetUpHandGun()); | ||
| else if (isClient) | ||
| CmdSetupHandGun(); | ||
| } |
| //ホストのみNetworkConnectionが確立される前にStartが呼び出されてしまうため、NetworkConnectionが確立するまで待つ。 | ||
| yield return this.UpdateAsObservable().FirstOrDefault(_ => connectionToClient.isReady).ToYieldInstruction(); | ||
| CmdSetupHandGun(); | ||
| } |
| [SyncVar] public int playerId = 0; | ||
| [SyncVar] public int teamId = 0; | ||
| static int team1PlayerCount = 0; | ||
| static int team2PlayerCount = 0; |
| } | ||
|
|
||
| [Command] | ||
| void CmdSetPlayerIdAndTeamId() |
There was a problem hiding this comment.
退出時の処理とかすぐに追加できそう？
teamPlayerCountの値をこの実装で処理するなら退出時にデクリメントしたいところ
退出時の処理が面倒ならプレイヤーが追加されるたびに各チームの人数を計算する実装に変えた方があとあと楽かも
There was a problem hiding this comment.
デクリメント部分にコメントつけるの忘れてました
退出時はここでデクリメントしてます
https://github.com/denx-jp/SSP/pull/95/files#diff-eb90a57904ef44cdd6e5abedc58c880fR228
言われて気づいたのですがなぜかteamId==2のときだけデクリメントしてないので修正しておきます
|
修正しました！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
対応Issue
確認項目