User access group test

[nk2136]

Test scenarios for User Access Group test -

1. Create group and add an employee
2. Import group from another leaf site and delete it
3. System admin search
4. View user group history

[mgaoVA]

Before requesting reviews, all tests should pass using this procedure:

1. Check that you are using the correct Git branches, and they are up to date
   • LEAF -> "master" branch
   • LEAF-Automated-Tests -> your working branch
2. Navigate to the Development dashboard (https://host.docker.internal/)
3. Click on "API tester", and wait for it to complete
4. Click on "End-to-End tests (Playwright)"

[aerinkayne]

This does not error on repeat runs, but I'm concerned that the test does not reflect it only being possible to create a group of a specific name once (even if it's subsequently deleted).

[mgaoVA]

Elaborating on the concern: Tests that involve creating and validating entries must not use fixed values. Subsequent runs of this test fail to validate intended functionality: whether the user can create groups. In this test, the second run actually skips the group creation because the group already exists (which would normally trigger an error).

Instead of:

  await groupTitle.fill('New Test Group 0');

A more complete solution would be:

let randNum = Math.random();
let uniqueText = `New Test Group ${randNum}`;

await groupTitle.fill(uniqueText);

[nk2136]

fixed

[mgaoVA]

1. Please update the PR description to reflect changes in scope. Since tests were removed, the description should reflect it.

2. When naming tests, try to think about the procedure from the end-user's perspective. For example, instead of "Validate group creation and an employee addition", a more concise label would be "create group and add employee". It's not necessary to explain that the test is doing validation -- this is implied since all tests are fundamentally validating functionality.

3. The "waitFor" in this pattern is redundant because the second line automatically waits:

  await group.waitFor();
  await group.click();

5. To improve repeatability, it would be prudent to expand certain tests. For example, when importing a group, it's easier to also remove it within the same test so that subsequent runs fully exercise the intended functionality. Currently these tests trigger an error, but it doesn't show up because it's based on an asynchronous transaction, and the test's locators end up skipping it.