Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import form test #27

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Import form test #27

wants to merge 6 commits into from

Conversation

crystalkirscht
Copy link
Contributor

Added a test for importing forms and removed extra spaces in Section Heading name

@aerinkayne
Copy link
Contributor

Tests will run where the main.js file is, which is why form files are being created in LEAF-Automated-Tests/endtoend/LEAF-Automated-Tests/endtoend/forms. The path can just be referred to as './forms'.

It seems there should be a way to delete the download afterwards as well, but I'm unclear from some filechooser github comments if that might be buggy.

These otherwise look good.

aerinkayne
aerinkayne approved these changes Dec 31, 2024
View reviewed changes
Copy link
Contributor

@aerinkayne aerinkayne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked at Playwrite some more, and I guess their 'delete' won't work in this context (which is reassuring actually...). Maybe we can just gitignore the folder for test dowloads.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaneodd shaneodd shaneodd approved these changes

@aerinkayne aerinkayne aerinkayne approved these changes

@Pelentan Pelentan Pelentan approved these changes

@mgaoVA mgaoVA Awaiting requested review from mgaoVA mgaoVA is a code owner

@pete-nerantzinis pete-nerantzinis Awaiting requested review from pete-nerantzinis pete-nerantzinis is a code owner

@jampaul3 jampaul3 Awaiting requested review from jampaul3 jampaul3 is a code owner

@nk2136 nk2136 Awaiting requested review from nk2136 nk2136 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crystalkirscht @aerinkayne @Pelentan @shaneodd