3540 remove set-env-secrets.src and references (#3632)

<!-- Ensure the PR title reflects the feature or bug name -->

## What was the problem?
ArgoCD secrets migration made the bundled secret previously used to
inject environment variables into a pod redundant; the unpacking code
and references to it have been removed. Keeping the script meant the
legacy bundled secrets which were kept around for legacy reasons were
overwriting secrets provided by Vault, and so it needed to be removed.
The bundled secrets are to be removed in the argocd-applications-vault
repo.

Associated tickets or Slack threads:
- #3540 

## How does this fix it?[^1]
Not performing the `set-env-secrets.src` steps means secrets injected
from Vault will not be overwritten by old versions of the secrets.

[^1]: [Pull-Requests
guidelines](https://github.com/department-of-veterans-affairs/abd-vro/wiki/Pull-Requests).
If PR is significant, update [Current Software
State](https://github.com/department-of-veterans-affairs/abd-vro/wiki/Current-Software-State)
wiki page.
[^secrel]: To check if a PR will succeed in the SecRel workflow, [test
PRs in the SecRel
pipeline](https://github.com/department-of-veterans-affairs/abd-vro-internal/wiki/Secure-Release-process#to-test-prs-in-the-secrel-pipeline).

gradle-plugins/src/main/groovy/shared.docker.container-conventions.gradle

@@ -53,7 +53,6 @@ docker {
     // Specify files to copy into Docker build context
     files "docker-entryprep.sh", "docker-entrypoint.sh"
     copyFromResources(copySpec, [
-        '/docker/set-env-secrets.src',
         '/docker/entrypoint-wrapper.sh'
     ])
 }

gradle-plugins/src/main/resources/docker/Dockerfile-java

@@ -13,7 +13,7 @@ WORKDIR /app
 
 # https://stackoverflow.com/a/46801962
 # Copy script that runs docker-entrypoint.sh if it exists, otherwise run jar file
-COPY set-env-secrets.src entrypoint-wrapper.sh docker-entry*.sh ./
+COPY entrypoint-wrapper.sh docker-entry*.sh ./
 
 ARG JAR_FILE
 ENV JAR_FILENAME=${JAR_FILE}

gradle-plugins/src/main/resources/docker/Dockerfile-python

@@ -27,7 +27,7 @@ RUN pip install --default-timeout=100 --no-cache-dir -r requirements.txt
 
 # https://stackoverflow.com/a/46801962
 # Copy script that runs docker-entrypoint.sh if it exists
-COPY set-env-secrets.src entrypoint-wrapper.sh docker-entry*.sh ./
+COPY entrypoint-wrapper.sh docker-entry*.sh ./
 
 # Copy application code, which changes more often,
 # along with files specified in local.python.container-service-convention

gradle-plugins/src/main/resources/docker/entrypoint-wrapper.sh

@@ -4,9 +4,6 @@
 # and local.python.container-service-convention.
 # To run your own script, create docker-entrypoint.sh in your Gradle module.
 
-# Sets environment variable secrets
-[ -e set-env-secrets.src ] && . ./set-env-secrets.src
-
 if [ -e /app/docker-entryprep.sh ]; then
   . /app/docker-entryprep.sh "$@"
 fi

svc-bgs-api/Dockerfile

@@ -24,7 +24,7 @@ RUN gem install bundler:2.5.4 --no-document && \
 
 # https://stackoverflow.com/a/46801962
 # Copy script that runs docker-entrypoint.sh if it exists
-COPY set-env-secrets.src entrypoint-wrapper.sh docker-entry*.sh ./
+COPY entrypoint-wrapper.sh docker-entry*.sh ./
 
 # === Image layers above this line are general and will be reused as cache when building the image.
 # Put commands that produce project-specific image layers below this line.

vro-streamlit/Dockerfile

@@ -33,7 +33,7 @@ RUN pip install --default-timeout=100 --no-cache-dir -r requirements.txt
 
 # https://stackoverflow.com/a/46801962
 # Copy script that runs docker-entrypoint.sh if it exists
-COPY set-env-secrets.src entrypoint-wrapper.sh docker-entry*.sh ./
+COPY entrypoint-wrapper.sh docker-entry*.sh ./
 
 # Copy application code, which changes more often,
 # along with files specified in local.python.container-service-convention