Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

va-language-toggle: Address accessibility issues #1484

Merged
merged 2 commits into from
Feb 11, 2025
Merged

va-language-toggle: Address accessibility issues #1484

merged 2 commits into from
Feb 11, 2025

Conversation

ataker
Copy link
Contributor

@ataker ataker commented Feb 6, 2025 •
edited
Loading

Chromatic

https://lang-toggle-accessibility--65a6e2ed2314f7b8f98609d8.chromatic.com

Description

Closes Language toggle accessibility updates #3564

QA Checklist

  • Component maintains 1:1 parity with design mocks
  • Text is consistent with what's been provided in the mocks
  • Component behaves as expected across breakpoints
  • Accessibility expert has signed off on code changes (if applicable. If not applicable provide reason why)
  • Designer has signed off on changes (if applicable. If not applicable provide reason why)
  • Tab order and focus state work as expected
  • Changes have been tested against screen readers (if applicable. If not applicable provide reason why)
  • New components are covered by e2e tests; updates to existing components are covered by existing test suite
  • Changes have been tested in vets-website using Verdaccio (if applicable. If not applicable provide reason why)

Screenshots

Screenshot 2025-02-06 at 09 37 54

Screenshot 2025-02-06 at 09 38 03

Acceptance criteria

  • QA checklist has been completed
  • Screenshots have been attached that cover desktop and mobile screens

Definition of done

  • Documentation has been updated, if applicable
  • A link has been provided to the originating GitHub issue (or connected to it via ZenHub)

@ataker ataker added the patch Patch change in semantic versioning label Feb 6, 2025
@ataker ataker requested a review from a team as a code owner February 6, 2025 14:39
ataker
ataker commented Feb 6, 2025
View reviewed changes
packages/web-components/src/components/va-language-toggle/va-language-toggle.tsx
href={href}
hrefLang={lang}
onClick={(e) => this.handleToggle(e, lang, label)}
aria-current={"language"}
Copy link
Contributor Author

@ataker ataker Feb 6, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aria-current={"language"} resolves to aria-current="true", but I figure the extra information can't hurt.

rsmithadhoc
rsmithadhoc approved these changes Feb 10, 2025
View reviewed changes
Copy link
Contributor

@rsmithadhoc rsmithadhoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for a11y, thanks!

LWWright7
LWWright7 approved these changes Feb 11, 2025
View reviewed changes
Copy link

@LWWright7 LWWright7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!!

@ataker ataker merged commit 4bfac9d into main Feb 11, 2025
12 checks passed
@ataker ataker deleted the lang-toggle-accessibility branch February 11, 2025 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Andrew565 Andrew565 Andrew565 approved these changes

@rsmithadhoc rsmithadhoc rsmithadhoc approved these changes

@LWWright7 LWWright7 LWWright7 approved these changes

Assignees
No one assigned
Labels
patch Patch change in semantic versioning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Language toggle accessibility updates
4 participants
@ataker @Andrew565 @rsmithadhoc @LWWright7